From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH RFC 0/3] Virtio draft III Date: Sun, 17 Jun 2007 17:14:55 +0300 Message-ID: <467541DF.5060907@qumranet.com> References: <1181217762.14054.192.camel@localhost.localdomain> <1181999552.6237.255.camel@localhost.localdomain> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: Stephen Rothwell , Xen Mailing List , "jmk-zzFmDc4TPjtKvsKVC3L/VUEOCMrvLtNR@public.gmane.org" , Herbert Xu , kvm-devel , virtualization , Christian Borntraeger , Latchesar Ionkov , Suzanne McIntosh , Martin Schwidefsky To: Rusty Russell Return-path: In-Reply-To: <1181999552.6237.255.camel-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org Errors-To: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: kvm.vger.kernel.org Rusty Russell wrote: > In this episode, Rusty tries to NAPI-ize the driver and discovers that > virtio callbacks are a bad idea: NAPI needs to turn interrupts off and > still be able to query for new incoming packets. > > Changes to core: > 1) Back to "interrupt" model with get_inbuf()/get_outbuf() calls. > Seems to be these are just two different ways of iterating over the pending buffers, and one could be implemented in terms of the other in a few lines. I think that new new way is better, though, due to less indirection. btw, I'm not sure that the name 'virtio' is correct. Probably any network or block driver which has support for batching (the vast majority) could use this to good effect. -- error compiling committee.c: too many arguments to function ------------------------------------------------------------------------- This SF.net email is sponsored by DB2 Express Download DB2 Express C - the FREE version of DB2 express and take control of your XML. No limits. Just data. Click to get it now. http://sourceforge.net/powerbar/db2/