From mboxrd@z Thu Jan  1 00:00:00 1970
From: Avi Kivity <avi-atKUWr5tajBWk0Htik3J/w@public.gmane.org>
Subject: Re: [PATCH RFC 3/3] Virtio draft III: example block
	driver
Date: Mon, 18 Jun 2007 12:09:09 +0300
Message-ID: <46764BB5.6070704@qumranet.com>
References: <1181217762.14054.192.camel@localhost.localdomain>	
	<1181999552.6237.255.camel@localhost.localdomain>	
	<1181999669.6237.257.camel@localhost.localdomain>	
	<1181999825.6237.260.camel@localhost.localdomain>	
	<1181999920.6237.263.camel@localhost.localdomain>	
	<46754451.2010305@qumranet.com>
	<1182154095.19064.24.camel@localhost.localdomain>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Cc: Stephen Rothwell <sfr-3FnU+UHB4dNDw9hX6IcOSA@public.gmane.org>,
	Xen Mailing List <xen-devel-GuqFBffKawuULHF6PoxzQEEOCMrvLtNR@public.gmane.org>,
	"jmk-zzFmDc4TPjtKvsKVC3L/VUEOCMrvLtNR@public.gmane.org" <jmk-zzFmDc4TPjtKvsKVC3L/VUEOCMrvLtNR@public.gmane.org>,
	kvm-devel <kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org>,
	virtualization <virtualization-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org>,
	Christian Borntraeger <cborntra-tA70FqPdS9bQT0dZR+AlfA@public.gmane.org>,
	Latchesar Ionkov <lionkov-YOWKrPYUwWM@public.gmane.org>,
	Suzanne McIntosh <skranjac-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>,
	Jens Axboe <jens.axboe-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>,
	Martin Schwidefsky <schwidefsky-tA70FqPdS9bQT0dZR+AlfA@public.gmane.org>
To: Rusty Russell <rusty-8n+1lVoiYb80n/F98K4Iww@public.gmane.org>
Return-path: <kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org>
In-Reply-To: <1182154095.19064.24.camel-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>
List-Unsubscribe: <https://lists.sourceforge.net/lists/listinfo/kvm-devel>,
	<mailto:kvm-devel-request-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org?subject=unsubscribe>
List-Archive: <http://sourceforge.net/mailarchive/forum.php?forum_name=kvm-devel>
List-Post: <mailto:kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org>
List-Help: <mailto:kvm-devel-request-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org?subject=help>
List-Subscribe: <https://lists.sourceforge.net/lists/listinfo/kvm-devel>,
	<mailto:kvm-devel-request-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org?subject=subscribe>
Sender: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
Errors-To: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
List-Id: kvm.vger.kernel.org

Rusty Russell wrote:
> On Sun, 2007-06-17 at 17:25 +0300, Avi Kivity wrote:
>   
>> Rusty Russell wrote:
>>     
>>> +	/* Set up for reply. */
>>> +	vblk->sg[0].page = virt_to_page(&vbr->in_hdr);
>>> +	vblk->sg[0].offset = offset_in_page(&vbr->in_hdr);
>>> +	vblk->sg[0].length = sizeof(vbr->in_hdr);
>>> +	num = blk_rq_map_sg(q, vbr->req, vblk->sg+1);
>>> +	vbr->out_hdr.id = vblk->vdev->ops->add_inbuf(vblk->vdev, vblk->sg,
>>> +						     1+num, vbr);
>>> +	if (IS_ERR_VALUE(vbr->out_hdr.id))
>>> +		goto full;
>>> +
>>> +	vblk->sg[0].page = virt_to_page(&vbr->out_hdr);
>>> +	vblk->sg[0].offset = offset_in_page(&vbr->out_hdr);
>>> +	vblk->sg[0].length = sizeof(vbr->out_hdr);
>>> +
>>> +	vbr->out_id = vblk->vdev->ops->add_outbuf(vblk->vdev, vblk->sg, 1,
>>> +						  vbr);
>>>       
>> This strikes me as wasteful.  Why not set up a single descriptor which 
>> contains both placement and the data itself?
>>     
>
> We could actually do this for write, but not for read (where the length
> & sector need to be sent to other end, and the data comes from other
> end).
>
>   

So you map the first sg entry for output, and the rest for input.

Less pretty, but more efficient.

-- 
error compiling committee.c: too many arguments to function


-------------------------------------------------------------------------
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/