Re: [PATCH 5/5] KVM: paravirt time source

Anthony Liguori
2007-06-19T20:38:51Z

Jeremy Fitzhardinge wrote:
>> + .read = read_hyper,
>> + .mask = CLOCKSOURCE_MASK(64),
>> + .mult = 1,
>> + .shift = 0,
>>
>>
>
> It would be better to use a scale and shift here, so that adjtime has
> something to work with when warping time.
>

I've updated this patch and switched to using a scale/shift like Xen is
doing, but I must admit, I don't understand how it helps adjtime. I
poked around a bit and it wasn't obvious.

Why is having {mult=1<<22, shift=22} better for adjtime than {mult=1,
shift=0}?

Regards,

ANthony Liguori

> J