Re: [PATCH 3/5] KVM: Add paravirt MMU write support

Anthony Liguori
2007-06-18T12:48:16Z

Avi Kivity wrote:
> Anthony Liguori wrote:
>>>
>>> Hypercalls should return kvm-specific error codes (defined in
>>> include/linux/kvm_para.h), not Linux error codes, as they could be
>>> used in operating systems which have different values for E2BIG and
>>> friends.
>>
>> If Linux's errnos are stable, we could just use them and let a
>> non-Linux guest define a set of KVM_E2BIG, etc.? It just seemed
>> pretty ugly to add a bunch of these.
>
> The ugliness will serve to remind us that this is a potentially
> non-Linux path.
>
> In this particular case, the names are not present in guest-visible
> headers, but any other that is made visible must have a
> non-Linux-dependent name, so I don't see why error numbers should be
> treated specially.

Ok.

Regards,

Anthony LIguori