[patch] emit more information on the emulation failure

[patch] emit more information on the emulation failure

[Kamble, Nitin A]

[-- Attachment #1.1.1.1: Type: text/plain, Size: 541 bytes --]

Hi Avi,

Attached is a small patch to emit little bit more information when
emulcation reaches cannot_emulate:.


The patch looks fine to the scripts/checkpatch.pl. It show not look to
you in the DOS format, unless something in between us is changing the
format of the attachment.

Please comment/apply.
  
Thanks & Regards,
Nitin 
Open Source Technology Center, Intel Corporation.
-------------------------------------------------------------------------
The mind is like a parachute; it works much better when it's open. 

[-- Attachment #1.1.1.2: Type: text/html, Size: 1182 bytes --]

[-- Attachment #1.1.2: emulate_fail_log.patch --]
[-- Type: text/x-patch, Size: 688 bytes --]

commit 4e368156a9d2e613b50278c73b12a84dda7adcd1
Author: Nitin A Kamble <nitin.a.kamble@intel.com>
Date:   Mon Jun 18 19:18:55 2007 -0700

    Printing more details when the x86 emulator fails to emulate.
    
    
    Signed-off-by: Nitin A Kamble <nitin.a.kamble@intel.com>

diff --git a/drivers/kvm/x86_emulate.c b/drivers/kvm/x86_emulate.c
index a4a8481..59511c6 100644
--- a/drivers/kvm/x86_emulate.c
+++ b/drivers/kvm/x86_emulate.c
@@ -1350,7 +1350,8 @@ twobyte_special_insn:
 	goto writeback;
 
 cannot_emulate:
-	DPRINTF("Cannot emulate %02x\n", b);
+	DPRINTF("Cannot emulate %02x at 0x%lx:0x%lx\n",
+			b, ctxt->cs_base, ctxt->vcpi->rip);
 	return -1;
 }
 

[-- Attachment #1.2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 189 bytes --]

[-- Attachment #2: Type: text/plain, Size: 286 bytes --]

-------------------------------------------------------------------------
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/

[-- Attachment #3: Type: text/plain, Size: 186 bytes --]

_______________________________________________
kvm-devel mailing list
kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
https://lists.sourceforge.net/lists/listinfo/kvm-devel

Re: [patch] emit more information on the emulation failure

[Avi Kivity]

Kamble, Nitin A wrote:
> Hi Avi,
>
> Attached is a small patch to emit little bit more information when 
> emulcation reaches cannot_emulate:.
>
>
> The patch looks fine to the scripts/checkpatch.pl. It show not look to 
> you in the DOS format, unless something in between us is changing the 
> format of the attachment.
>

> @@ -1350,7 +1350,8 @@ twobyte_special_insn:
>  	goto writeback;
>  
>  cannot_emulate:
> -	DPRINTF("Cannot emulate %02x\n", b);
> +	DPRINTF("Cannot emulate %02x at 0x%lx:0x%lx\n",
> +			b, ctxt->cs_base, ctxt->vcpi->rip);
>  	return -1;
>  }


How can this compile?  I think you need to replace ctxt->vcpi by ctxt->vcpu.


-- 
error compiling committee.c: too many arguments to function


-------------------------------------------------------------------------
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/