From mboxrd@z Thu Jan 1 00:00:00 1970 From: Anthony Liguori Subject: Re: Duplicate content in files Date: Tue, 19 Jun 2007 16:11:04 -0500 Message-ID: <46784668.2060106@codemonkey.ws> References: <46783DC8.2010006@ev-en.org> <68676e00706191346r615b798emd90be772ac3bdd45@mail.gmail.com> <46784183.4070502@ev-en.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org To: Baruch Even Return-path: In-Reply-To: <46784183.4070502-6P1Dz+XQpLLYtjvyW6yDsg@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org Errors-To: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: kvm.vger.kernel.org Baruch Even wrote: > Luca wrote: > >> On 6/19/07, Baruch Even wrote: >> >>> Hello, >>> >>> I've tried to diff kvm-28 qemu directory with qemu 0.9.0 and I see that >>> some files in the kvm sources have the content of the file duplicated, >>> f.ex. qemu/hw/mips_int.c has it's own content twice in the kvm tree, it >>> only has it once in qemu as it should be. Look for the include >>> directives and you'll see what I mean. >>> >>> There are several other files like that. >>> >> Funny :-) Clearly they're unused in KVM (only x86* is compiled) >> otherwise the linker would scream :P >> According to GIT those files haven't been touched, something went >> wrong during the initial import. >> > > My problem is that I'm now looking at applying "the kvm patch" into the > Debian qemu so we will remove the need for a special package, in this > case these files will become in use and I'd like to be able to easily > track kvm upstream and update the Debian qemu package. > > For this to happen I need the kvm tree to be clean in relation to qemu > and this issue is going to make it a pain to maintain such a patch. > A patch to eliminate this stuff would be very nice! Regards, Anthony Liguori > Will the kvm dev folks accept a patch to correct such mistakes? > Baruch > > ------------------------------------------------------------------------- > This SF.net email is sponsored by DB2 Express > Download DB2 Express C - the FREE version of DB2 express and take > control of your XML. No limits. Just data. Click to get it now. > http://sourceforge.net/powerbar/db2/ > _______________________________________________ > kvm-devel mailing list > kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org > https://lists.sourceforge.net/lists/listinfo/kvm-devel > > ------------------------------------------------------------------------- This SF.net email is sponsored by DB2 Express Download DB2 Express C - the FREE version of DB2 express and take control of your XML. No limits. Just data. Click to get it now. http://sourceforge.net/powerbar/db2/