Re: In kernel PIC support: kernel patch

Gregory Haskins
2007-06-25T13:45:08Z

On Sun, 2007-06-24 at 23:28 -0400, Avi Kivity wrote:
> Dong, Eddie wrote:
> >> Need to add a way to detect if this functionality is available, via
> >> KVM_CHECK_EXTENSION.
> >>
> >
> > Sure. Question:
> > Should we check the extension API basis or feature sets list?
> > I.e. Each API (KVM_CREATE_PIC, KVM_SET_ISA_IRQ_LEVEL) or feature sets:
> > KVM_KERNEL_IRQCHIP.
> >
> >
>
> I guess pre-feature. We want to have fine granularity so we can change
> small things, but per-API is too fine.
>
> So in this case I'd suggest KVM_CAP_PIC, KVM_CAP_APIC, etc. (note the
> KVM_CAP_* namespace).

Yeah, I like this suggestion better than how I currently do it.