From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: In kernel PIC support: kernel patch Date: Sat, 23 Jun 2007 10:50:16 +0300 Message-ID: <467CD0B8.9090201@qumranet.com> References: <10EA09EFD8728347A513008B6B0DA77A01A55F0A@pdsmsx411.ccr.corp.intel.com> <467BA95A.704@qumranet.com> <1182522074.17478.45.camel@localhost.localdomain> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org To: Rusty Russell Return-path: In-Reply-To: <1182522074.17478.45.camel-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org Errors-To: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: kvm.vger.kernel.org Rusty Russell wrote: > On Fri, 2007-06-22 at 13:50 +0300, Avi Kivity wrote: > >> Dong, Eddie wrote: >> >>> + >>> +/* set irq level. If an edge is detected, then the IRR is set to 1 */ >>> >>> >> Kernel comments like this: >> >> /* >> * blah blah blah >> */ >> >> This comment applies to the rest of the patch. >> > > For one-liners? Last I paid attention the main debate was about > multi-line comments. > I'd say for multiline comments and function headers. ------------------------------------------------------------------------- This SF.net email is sponsored by DB2 Express Download DB2 Express C - the FREE version of DB2 express and take control of your XML. No limits. Just data. Click to get it now. http://sourceforge.net/powerbar/db2/