From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH RFC 2/3] Virtio draft III: example net driver Date: Mon, 25 Jun 2007 17:54:33 -0400 Message-ID: <46803999.4040500@qumranet.com> References: <1181217762.14054.192.camel@localhost.localdomain> <1181999552.6237.255.camel@localhost.localdomain> <1181999669.6237.257.camel@localhost.localdomain> <1181999825.6237.260.camel@localhost.localdomain> <467FDEAD.4030204@linux.vnet.ibm.com> <20070625193304.GB25736@infradead.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: Stephen Rothwell , Xen Mailing List , "jmk-zzFmDc4TPjtKvsKVC3L/VUEOCMrvLtNR@public.gmane.org" , Herbert Xu , kvm-devel , virtualization , Christian Borntraeger , Latchesar Ionkov , Suzanne McIntosh , Brian King , Martin Schwidefsky To: Christoph Hellwig Return-path: In-Reply-To: <20070625193304.GB25736-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org Errors-To: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: kvm.vger.kernel.org Christoph Hellwig wrote: > On Mon, Jun 25, 2007 at 10:26:37AM -0500, Brian King wrote: > >> 1. The add_inbuf interface passes an sg list. This causes problems for >> ibmveth since its rx buffers cannot be scatterlists. >> I'm probably missing something. What is wrong with a scatterlist of length 1? >> 2. The user of this API does not have access to the sk_buf. This causes >> issues for ibmveth since it needs to reserve the first 8 bytes of the >> rx buffer for use by the firmware. It currently uses skb_reserve to do this. >> >> Would it be simpler to just pass an sk_buf rather than the scatterlist >> on these interfaces for virtio_net users? >> > > It probably should pass the sk_buff. But virtio is a generic layer that is useful for more than just networking. ------------------------------------------------------------------------- This SF.net email is sponsored by DB2 Express Download DB2 Express C - the FREE version of DB2 express and take control of your XML. No limits. Just data. Click to get it now. http://sourceforge.net/powerbar/db2/