Re: [PATCH RFC 0/3] Virtio draft III

Avi Kivity
2007-06-17T14:14:55Z

Rusty Russell wrote:
> In this episode, Rusty tries to NAPI-ize the driver and discovers that
> virtio callbacks are a bad idea: NAPI needs to turn interrupts off and
> still be able to query for new incoming packets.
>
> Changes to core:
> 1) Back to "interrupt" model with get_inbuf()/get_outbuf() calls.
>

Seems to be these are just two different ways of iterating over the
pending buffers, and one could be implemented in terms of the other in a
few lines. I think that new new way is better, though, due to less
indirection.

btw, I'm not sure that the name 'virtio' is correct. Probably any
network or block driver which has support for batching (the vast
majority) could use this to good effect.

--
error compiling committee.c: too many arguments to function