Re: [PATCH RFC 2/3] Virtio draft III: example net driver

Avi Kivity
2007-06-25T21:54:33Z

Christoph Hellwig wrote:
> On Mon, Jun 25, 2007 at 10:26:37AM -0500, Brian King wrote:
>
>> 1. The add_inbuf interface passes an sg list. This causes problems for
>> ibmveth since its rx buffers cannot be scatterlists.
>>

I'm probably missing something. What is wrong with a scatterlist of
length 1?

>> 2. The user of this API does not have access to the sk_buf. This causes
>> issues for ibmveth since it needs to reserve the first 8 bytes of the
>> rx buffer for use by the firmware. It currently uses skb_reserve to do this.
>>
>> Would it be simpler to just pass an sk_buf rather than the scatterlist
>> on these interfaces for virtio_net users?
>>
>
> It probably should pass the sk_buff.

But virtio is a generic layer that is useful for more than just networking.