Re: [PATCH] Make sure to sync registers in monitor/gdbstub

[Anthony Liguori <anthony-rdkfGonbjUSkNkDKm+mE6A@public.gmane.org>]

Avi Kivity wrote:
> Anthony Liguori wrote:
>   
>> This patch adds support to gdbstub and the monitor to sync CPU state before
>> and after the user views/changes it.
>>
>> Signed-off-by: Anthony Liguori <aliguori-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
>>
>> diff --git a/qemu/gdbstub.c b/qemu/gdbstub.c
>> index c33a66e..a3b82af 100644
>> --- a/qemu/gdbstub.c
>> +++ b/qemu/gdbstub.c
>> @@ -30,6 +30,7 @@
>>  #include "qemu.h"
>>  #else
>>  #include "vl.h"
>> +#include "qemu-kvm.h"
>>  #endif
>>  
>>  #include "qemu_socket.h"
>> @@ -871,6 +872,9 @@ static int gdb_handle_packet(GDBState *s, CPUState *env, const char *line_buf)
>>              addr = strtoull(p, (char **)&p, 16);
>>  #if defined(TARGET_I386)
>>              env->eip = addr;
>> +#ifdef USE_KVM
>> +	    kvm_load_registers(env);
>> +#endif
>>   
>>     
>
> You need some if (kvm_allowed) checks in there, no?
>   

Yup, new patch sent.

Regards,

Anthony Liguori

>
> -------------------------------------------------------------------------
> This SF.net email is sponsored by DB2 Express
> Download DB2 Express C - the FREE version of DB2 express and take
> control of your XML. No limits. Just data. Click to get it now.
> http://sourceforge.net/powerbar/db2/
> _______________________________________________
> kvm-devel mailing list
> kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
> https://lists.sourceforge.net/lists/listinfo/kvm-devel
>
>   


-------------------------------------------------------------------------
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/