From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH][RFC] kvm-scheduler integration Date: Sun, 08 Jul 2007 16:41:07 +0300 Message-ID: <4690E973.7000606@qumranet.com> References: <11838994974161-git-send-email-avi@qumranet.com> <20070708133539.GA12597@elte.hu> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Ingo Molnar Return-path: In-Reply-To: <20070708133539.GA12597-X9Un+BFzKDI@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org Errors-To: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: kvm.vger.kernel.org Ingo Molnar wrote: > * Avi Kivity wrote: > > >> +#ifdef CONFIG_SCHED_KVM >> +static __read_mostly struct sched_kvm_hooks kvm_hooks; >> +#endif >> > > please just add a current->put_vcpu() function pointer instead of this > hooks thing. > > Won't that increase task_struct (16 bytes on 64-bit) unnecessarily? The function pointers are common to all virtual machines. >> static inline void prepare_task_switch(struct rq *rq, struct task_struct *next) >> { >> + unload_kvm_vcpu(current); >> prepare_lock_switch(rq, next); >> prepare_arch_switch(next); >> } >> @@ -1860,6 +1912,7 @@ static inline void finish_task_switch(struct rq *rq, struct task_struct *prev) >> prev_state = prev->state; >> finish_arch_switch(prev); >> finish_lock_switch(rq, prev); >> + reload_kvm_vcpu(current); >> > > ok, this looks certainly cheap enough from a scheduler POV, and it > cleans up the whole KVM/scheduling interaction quite nicely. (I'd not > bother with tweaking the migration logic, there's enough incentive for > the scheduler to keep tasks from migrating unnecessarily.) > Okay. -- error compiling committee.c: too many arguments to function ------------------------------------------------------------------------- This SF.net email is sponsored by DB2 Express Download DB2 Express C - the FREE version of DB2 express and take control of your XML. No limits. Just data. Click to get it now. http://sourceforge.net/powerbar/db2/