From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH][RFC] kvm-scheduler integration Date: Sun, 08 Jul 2007 16:53:11 +0300 Message-ID: <4690EC47.6060904@qumranet.com> References: <11838994974161-git-send-email-avi@qumranet.com> <20070708133539.GA12597@elte.hu> <4690E973.7000606@qumranet.com> <20070708134850.GB22911@elte.hu> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Ingo Molnar Return-path: In-Reply-To: <20070708134850.GB22911-X9Un+BFzKDI@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org Errors-To: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: kvm.vger.kernel.org Ingo Molnar wrote: > * Avi Kivity wrote: > > >>>> +#ifdef CONFIG_SCHED_KVM >>>> +static __read_mostly struct sched_kvm_hooks kvm_hooks; >>>> +#endif >>>> >>> please just add a current->put_vcpu() function pointer instead of >>> this hooks thing. >>> >> Won't that increase task_struct (16 bytes on 64-bit) unnecessarily? >> The function pointers are common to all virtual machines. >> > > well, this function pointer could then be reused by other virtual > machines as well, couldnt it? I don't get this. If we add a couple of members to task_struct, it can't be reused. The values will be the same across all tasks, but the memory will be gone (including tasks which aren't virtual machines). > If the task struct overhead is a problem > (it really isnt, and it's dependent on CONFIG_KVM) then we could switch > it around to a notifier-alike mechanism. > I'm hoping that CONFIG_KVM will be enabled on most distro kernels, so we need to optimize for that case as well. -- error compiling committee.c: too many arguments to function ------------------------------------------------------------------------- This SF.net email is sponsored by DB2 Express Download DB2 Express C - the FREE version of DB2 express and take control of your XML. No limits. Just data. Click to get it now. http://sourceforge.net/powerbar/db2/