From mboxrd@z Thu Jan  1 00:00:00 1970
From: Avi Kivity <avi@qumranet.com>
Subject: Re: [PATCH 17/20] SMP: Implement on_cpu()
Date: Mon, 09 Jul 2007 12:40:00 +0300
Message-ID: <46920270.3080309@qumranet.com>
References: <11838956891287-git-send-email-avi@qumranet.com> <11838956893094-git-send-email-avi@qumranet.com> <p73lkdqzpdm.fsf@bingen.suse.de> <4691D9C1.4050309@qumranet.com> <20070709071640.GB10864@one.firstfloor.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Cc: linux-kernel@vger.kernel.org, KVM <kvm-devel@lists.sourceforge.net>
To: Andi Kleen <andi@firstfloor.org>
Return-path: <linux-kernel-owner+glk-linux-kernel-3=40m.gmane.org-S1755480AbXGIJkL@vger.kernel.org>
In-Reply-To: <20070709071640.GB10864@one.firstfloor.org>
Sender: linux-kernel-owner@vger.kernel.org
List-Id: kvm.vger.kernel.org

Andi Kleen wrote:
>> Well, smp_call_function_single() is arch specific whereas on_cpu() is
>>     
>
> Yes, but the few instances should be relatively easy to fix.
>
>   
>> generic code.  Perhaps rename smp_call_function_single() to
>> __smp_call_function_single() and on_cpu() to smp_call_function_single()?
>>     
>
> The low level function checks for this anyways. Instead of erroring
> it should just DTRT.
>   

Okay.  I'll make that change.


-- 
error compiling committee.c: too many arguments to function