From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH 17/20] SMP: Implement on_cpu() Date: Wed, 11 Jul 2007 10:26:30 +0300 Message-ID: <46948626.6050308@qumranet.com> References: <11838956891287-git-send-email-avi@qumranet.com> <4691D9C1.4050309@qumranet.com> <20070709071640.GB10864@one.firstfloor.org> <46920270.3080309@qumranet.com> <46921BE9.4040801@qumranet.com> <4693211D.4040406@qumranet.com> <46936766.20900@qumranet.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: KVM , Andrew Morton , Andi Kleen , linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Satyam Sharma Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org Errors-To: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: kvm.vger.kernel.org Satyam Sharma wrote: > > And I think what's proposed is: > > 1. Change smp_call_function() semantics, to run given function > on _all_ CPUs (thus getting rid of the on_each_cpu() "mistake") > > 2. Resort to (most probably implement another function?) using > smp_call_function_mask() or flags appropriately to also serve > the use cases where we need to run a given function on all > _other_ CPUs > > Does this pointless/gratuitous code-churn really make sense? > Definitely not to me ... It's not proposed. Andi mentioned it in passing. The only churn is in this thread. > > [ For the _single() case we now have on_cpu() as you originally > proposed, which I definitely like and fills the other gap in the API. ] > > So I still don't quite understand what is the need to change existing > semantics of smp_call_function{_single} in the first place. > I imagine Andi's motivation was that most uses benefit from this change, and the rest don't suffer. It's better not to have a proliferation of ever-so-similar APIs. -- error compiling committee.c: too many arguments to function ------------------------------------------------------------------------- This SF.net email is sponsored by DB2 Express Download DB2 Express C - the FREE version of DB2 express and take control of your XML. No limits. Just data. Click to get it now. http://sourceforge.net/powerbar/db2/