From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: rebase hlt emulation Date: Thu, 12 Jul 2007 12:53:17 +0300 Message-ID: <4695FA0D.3090207@qumranet.com> References: <4695BCA50200005A000275FE@mcclure.wal.novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org To: Gregory Haskins Return-path: In-Reply-To: <4695BCA50200005A000275FE-Igcdv/6uVdMHoYOw/+koYqIwWpluYiW7@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org Errors-To: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: kvm.vger.kernel.org Gregory Haskins wrote: > On Thu, 2007-07-12 at 13:33 +0800, Dong, Eddie wrote: > >> Here is the update with adding HLT cap. >> > > Thats a good start, but you probably need to make the decision to use > the halt predicated on a halt-specific boolean set by userspace in order > to actually function as we've discussed. This is in contrast to > overloading the decision with the presence of the in-kernel PIC. A > capability indicator without a way to turn it on/off is fairly useless, > IMHO. > > Conversely I don't think its a big deal to just skip the predicate all > together since your version of the patches wont cause as severe of an > issue as we had in hybrid mode. So I would say either make the full > conversion or drop the CAP altogether. > > I'd like to keep it as a precaution. If we later find out it's unneeded, we can rip it out (keeping the cap but always doing hlt in kernel, regardless of what the user wants). -- error compiling committee.c: too many arguments to function ------------------------------------------------------------------------- This SF.net email is sponsored by DB2 Express Download DB2 Express C - the FREE version of DB2 express and take control of your XML. No limits. Just data. Click to get it now. http://sourceforge.net/powerbar/db2/