From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: rebase hlt emulation Date: Thu, 12 Jul 2007 18:00:15 +0300 Message-ID: <469641FF.2090408@qumranet.com> References: <10EA09EFD8728347A513008B6B0DA77A01C24C36@pdsmsx411.ccr.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org To: "Dong, Eddie" Return-path: In-Reply-To: <10EA09EFD8728347A513008B6B0DA77A01C24C36-wq7ZOvIWXbNpB2pF5aRoyrfspsVTdybXVpNB7YpNyf8@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org Errors-To: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: kvm.vger.kernel.org Dong, Eddie wrote: > Gregory Haskins wrote: > >> On Thu, 2007-07-12 at 22:20 +0800, Dong, Eddie wrote: >> >> >> >>> Apply to current kvm.git? Then we need to define false for >>> irqchip_in_kernel() which makes the patch quit stranger. >>> >> I think what Avi is saying is this can be generalized as a separate >> feature independent of in-kernel-PIC. Since Avi and I are both >> advocating a separate capability for in-kernel-HLT, you >> wouldn't need to >> have a stubbed irqchip_in_kernel. Rather, you should have a flag that >> indicates whether userspace enabled the HLT capability or not. >> > > Then Avi need to check in your patch in user level to remove the race > condition, otherwise > the patch does nothing and just some dead code. > > Avi: > Can u have a double check to see what you want to do. I am fine > with either of them. > Like Gregory said: we check in the hlt patch to the kernel, and the race removal + use the new feature patch for userspace. Gregory, can you repost that patch please? Eddie, please test both with and without the userspace patch. -- error compiling committee.c: too many arguments to function ------------------------------------------------------------------------- This SF.net email is sponsored by DB2 Express Download DB2 Express C - the FREE version of DB2 express and take control of your XML. No limits. Just data. Click to get it now. http://sourceforge.net/powerbar/db2/