[PATCH] Fix QEMU target detection

[PATCH] Fix QEMU target detection

[Anthony Liguori]

This looks like a typo.  I think the intention of the if is to normalize
i[3456]86 to i386 since that's the target name for QEMU.

Signed-off-by: Anthony Liguori <aliguori-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>

diff --git a/configure b/configure
index d9292fe..e4d1ec6 100755
--- a/configure
+++ b/configure
@@ -74,7 +74,7 @@ fi
 
 target_cpu() {
     if [[ $(uname -m) = i?86 ]]; then
-	echo x86_64
+	echo i386
     else
 	uname -m
     fi

-------------------------------------------------------------------------
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/

Re: [PATCH] Fix QEMU target detection

[Avi Kivity]

Anthony Liguori wrote:
> This looks like a typo.  I think the intention of the if is to normalize
> i[3456]86 to i386 since that's the target name for QEMU.
>
> Signed-off-by: Anthony Liguori <aliguori-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
>
> diff --git a/configure b/configure
> index d9292fe..e4d1ec6 100755
> --- a/configure
> +++ b/configure
> @@ -74,7 +74,7 @@ fi
>  
>  target_cpu() {
>      if [[ $(uname -m) = i?86 ]]; then
> -	echo x86_64
> +	echo i386
>      else
>  	uname -m
>      fi
>   

This is intentional.  It allows migration from 32-bit hosts to 64-bit 
hosts.  Another side effect is that 64-bit guests can be run on 64-bit 
hosts with 32-bit userspace.

-- 
error compiling committee.c: too many arguments to function


-------------------------------------------------------------------------
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/

Re: [PATCH] Fix QEMU target detection

[Jun Koi]

On 7/10/07, Avi Kivity <avi-atKUWr5tajBWk0Htik3J/w@public.gmane.org> wrote:
> Anthony Liguori wrote:
> > This looks like a typo.  I think the intention of the if is to normalize
> > i[3456]86 to i386 since that's the target name for QEMU.
> >
> > Signed-off-by: Anthony Liguori <aliguori-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
> >
> > diff --git a/configure b/configure
> > index d9292fe..e4d1ec6 100755
> > --- a/configure
> > +++ b/configure
> > @@ -74,7 +74,7 @@ fi
> >
> >  target_cpu() {
> >      if [[ $(uname -m) = i?86 ]]; then
> > -     echo x86_64
> > +     echo i386
> >      else
> >       uname -m
> >      fi
> >
>
> This is intentional.  It allows migration from 32-bit hosts to 64-bit
> hosts.  Another side effect is that 64-bit guests can be run on 64-bit
> hosts with 32-bit userspace.
>

So now we always install qemu-system-x86-64 even on i686 box? I
noticed this when I installed from git repo today, and it really
confuses.

If so, all the old configuration must be modified to use
qemu-system-x86_64 rather than qemu like before. How about making a
soft-link that points qemu to qemu-system-x86_64?


Thanks,
Jun

-------------------------------------------------------------------------
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/

Re: [PATCH] Fix QEMU target detection

[Avi Kivity]

Jun Koi wrote:
> On 7/10/07, Avi Kivity <avi-atKUWr5tajBWk0Htik3J/w@public.gmane.org> wrote:
>> Anthony Liguori wrote:
>> > This looks like a typo.  I think the intention of the if is to
>> normalize
>> > i[3456]86 to i386 since that's the target name for QEMU.
>> >
>> > Signed-off-by: Anthony Liguori <aliguori-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
>> >
>> > diff --git a/configure b/configure
>> > index d9292fe..e4d1ec6 100755
>> > --- a/configure
>> > +++ b/configure
>> > @@ -74,7 +74,7 @@ fi
>> >
>> >  target_cpu() {
>> >      if [[ $(uname -m) = i?86 ]]; then
>> > -     echo x86_64
>> > +     echo i386
>> >      else
>> >       uname -m
>> >      fi
>> >
>>
>> This is intentional.  It allows migration from 32-bit hosts to 64-bit
>> hosts.  Another side effect is that 64-bit guests can be run on 64-bit
>> hosts with 32-bit userspace.
>>
>
> So now we always install qemu-system-x86-64 even on i686 box? I
> noticed this when I installed from git repo today, and it really
> confuses.
>
> If so, all the old configuration must be modified to use
> qemu-system-x86_64 rather than qemu like before. How about making a
> soft-link that points qemu to qemu-system-x86_64?
>

Distributions can rename as they see fit.  People on this list, or
others who compile from source can surely cope...

If anything, this will make scripts more common across different machines.

-- 
Do not meddle in the internals of kernels, for they are subtle and quick to panic.


-------------------------------------------------------------------------
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/