Re: [kvm-commits] kvm: external module: rename original kernel's modules when installing

Re: [kvm-commits] kvm: external module: rename original kernel's modules when installing

[Nguyen Anh Quynh]

[-- Attachment #1: Type: text/plain, Size: 707 bytes --]

On 7/12/07, Avi Kivity <avi-atKUWr5tajBWk0Htik3J/w@public.gmane.org> wrote:
> repository: /home/avi/kvm
> branch: master
> commit ebad9f20e60405fbf01beea7521c8a764391dece
> Author: Avi Kivity <avi-atKUWr5tajBWk0Htik3J/w@public.gmane.org>
> Date:   Thu Jul 12 13:20:47 2007 +0300
>
>     kvm: external module: rename original kernel's modules when installing
>
>     this avoids an ambiguity when using the kvm external module in conjuction
>     with 2.6.20 or later, which may also have kvm built.

This patch raises a problem if
/lib/modules/<version>/kernel/drivers/kvm/ does not exist.

The enclosed patch fixes the bug.

Signed-off-by: Nguyen Anh Quynh <aquynh-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>

[-- Attachment #2: patch12.patch --]
[-- Type: text/x-patch, Size: 420 bytes --]

diff --git a/kernel/Makefile b/kernel/Makefile
index 7eae95b..705d3fd 100644
--- a/kernel/Makefile
+++ b/kernel/Makefile
@@ -41,7 +41,7 @@ sync:
 install:
 	mkdir -p $(DESTDIR)/$(INSTALLDIR)
 	cp *.ko $(DESTDIR)/$(INSTALLDIR)
-	for i in $(ORIGMODDIR)/drivers/kvm/*.ko; do mv $$i $$i.orig; done
+	for i in $(ORIGMODDIR)/drivers/kvm/*.ko; do mv $$i $$i.orig; done || true
 	/sbin/depmod -a
 
 tmpspec = .tmp.kvm-kmod.spec

[-- Attachment #3: Type: text/plain, Size: 286 bytes --]

-------------------------------------------------------------------------
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/

[-- Attachment #4: Type: text/plain, Size: 186 bytes --]

_______________________________________________
kvm-devel mailing list
kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
https://lists.sourceforge.net/lists/listinfo/kvm-devel

Re: [kvm-commits] kvm: external module: rename original kernel's modules when installing

[Avi Kivity]

Nguyen Anh Quynh wrote:
> On 7/12/07, Avi Kivity <avi-atKUWr5tajBWk0Htik3J/w@public.gmane.org> wrote:
>> repository: /home/avi/kvm
>> branch: master
>> commit ebad9f20e60405fbf01beea7521c8a764391dece
>> Author: Avi Kivity <avi-atKUWr5tajBWk0Htik3J/w@public.gmane.org>
>> Date:   Thu Jul 12 13:20:47 2007 +0300
>>
>>     kvm: external module: rename original kernel's modules when 
>> installing
>>
>>     this avoids an ambiguity when using the kvm external module in 
>> conjuction
>>     with 2.6.20 or later, which may also have kvm built.
>
> This patch raises a problem if
> /lib/modules/<version>/kernel/drivers/kvm/ does not exist.
>
> The enclosed patch fixes the bug.

Fixed in a slightly different way; thanks.


-- 
error compiling committee.c: too many arguments to function


-------------------------------------------------------------------------
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/