From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: apic+ioapiuc patch Date: Tue, 17 Jul 2007 11:04:44 +0300 Message-ID: <469C781C.3040003@qumranet.com> References: <10EA09EFD8728347A513008B6B0DA77A01C72915@pdsmsx411.ccr.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org To: "Dong, Eddie" Return-path: In-Reply-To: <10EA09EFD8728347A513008B6B0DA77A01C72915-wq7ZOvIWXbNpB2pF5aRoyrfspsVTdybXVpNB7YpNyf8@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org Errors-To: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: kvm.vger.kernel.org Dong, Eddie wrote: > > >>> If guest is in hlt time, vcpu->guest_mode=0. (VM Exit always >>> >> clear this >> >>> one). >>> BTW, even we give a redunadant IPI, it is just a minor performance >>> >> issue >> >>> only. >>> >> I think that Avi was looking for the call to >> wake_up_interruptible(&vcpu->wq); >> Maybe it's hard to realize the apic code path where you call it. >> >> > O, yes, that is should be in hlt emulation code. > That depends on the order of patches... if hlt goes in first, this needs to be fixed. (I don't mind the order here really) -- error compiling committee.c: too many arguments to function ------------------------------------------------------------------------- This SF.net email is sponsored by DB2 Express Download DB2 Express C - the FREE version of DB2 express and take control of your XML. No limits. Just data. Click to get it now. http://sourceforge.net/powerbar/db2/