From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH 2/3] KVM - Fix hypercall arguments Date: Tue, 17 Jul 2007 11:15:26 +0300 Message-ID: <469C7A9E.30207@qumranet.com> References: <20070716192447.GA16248@c2.user-mode-linux.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: KVM devel , Jeff Dike , LKML To: Anthony Liguori Return-path: In-Reply-To: <20070716192447.GA16248-1LLyehjZOUUZWFFyALql+T+iFHGzDt/a@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org Errors-To: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: kvm.vger.kernel.org Jeff Dike wrote: > It looks like kvm_hypercall is trying to match the system call > convention and mixed up the call number and first argument in the > 32-bit case. > > Signed-off-by: Jeff Dike > -- > drivers/kvm/kvm_main.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > Index: kvm/drivers/kvm/kvm_main.c > =================================================================== > --- kvm.orig/drivers/kvm/kvm_main.c > +++ kvm/drivers/kvm/kvm_main.c > @@ -1351,8 +1351,8 @@ int kvm_hypercall(struct kvm_vcpu *vcpu, > } else > #endif > { > - nr = vcpu->regs[VCPU_REGS_RBX] & -1u; > - a0 = vcpu->regs[VCPU_REGS_RAX] & -1u; > + nr = vcpu->regs[VCPU_REGS_RAX] & -1u; > + a0 = vcpu->regs[VCPU_REGS_RBX] & -1u; > a1 = vcpu->regs[VCPU_REGS_RCX] & -1u; > a2 = vcpu->regs[VCPU_REGS_RDX] & -1u; > a3 = vcpu->regs[VCPU_REGS_RSI] & -1u; > Anthony? I think you were hacking this area? -- error compiling committee.c: too many arguments to function ------------------------------------------------------------------------- This SF.net email is sponsored by DB2 Express Download DB2 Express C - the FREE version of DB2 express and take control of your XML. No limits. Just data. Click to get it now. http://sourceforge.net/powerbar/db2/