From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH 2/10] Trivial: Remove KVM_IRQ_BITMAP macro Date: Wed, 18 Jul 2007 12:12:27 +0300 Message-ID: <469DD97B.3000905@qumranet.com> References: <1184677946.10380.4.camel@localhost.localdomain> <1184678060.10380.7.camel@localhost.localdomain> <469CC367.1000107@qumranet.com> <1184727958.10380.54.camel@localhost.localdomain> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: kvm-devel To: Rusty Russell Return-path: In-Reply-To: <1184727958.10380.54.camel-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org Errors-To: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: kvm.vger.kernel.org Rusty Russell wrote: > On Tue, 2007-07-17 at 16:25 +0300, Avi Kivity wrote: > >> Rusty Russell wrote: >> >>> Creating one's own BITMAP macro seems suboptimal: if we use manual >>> arithmetic in the one place exposed to userspace, we can use standard >>> macros elsewhere. >>> >>> The - 7 + 8 calc is overkill: can NR_IRQ_WORDS ever really change? >>> >>> >> Looks like it can: >> > > Sure, but the number 256 is part of the x86 architecture. A paravirt > guest could choose to have more interrupts, but is there really a point? > > I meant that you yourself, Rusty Russell, extended it to 2048 with your arithmetic. Sorry for being unclear. > Doh, fixed here: > == > Use standard BITMAP macros, open-code userspace-exposed header. > > Creating one's own BITMAP macro seems suboptimal: if we use manual > arithmetic in the one place exposed to userspace, we can use standard > macros elsewhere. > > Applied, thanks. -- Do not meddle in the internals of kernels, for they are subtle and quick to panic. ------------------------------------------------------------------------- This SF.net email is sponsored by DB2 Express Download DB2 Express C - the FREE version of DB2 express and take control of your XML. No limits. Just data. Click to get it now. http://sourceforge.net/powerbar/db2/