From: Avi Kivity <avi-atKUWr5tajBWk0Htik3J/w@public.gmane.org>
To: Gregory Haskins <ghaskins-Et1tbQHTxzrQT0dZR+AlfA@public.gmane.org>
Cc: kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
Subject: Re: [kvm-commits] Revert "kvm: qemu: initialize ata ports as enabled"
Date: Wed, 18 Jul 2007 15:42:47 +0300 [thread overview]
Message-ID: <469E0AC7.1000903@qumranet.com> (raw)
In-Reply-To: <469DCFDC0200005A00027C77-Igcdv/6uVdMHoYOw/+koYqIwWpluYiW7@public.gmane.org>
Gregory Haskins wrote:
> On Wed, 2007-07-18 at 12:20 +0300, Avi Kivity wrote:
>
>> repository: /home/avi/kvm
>> branch: master
>> commit a4d8dd22718d59fbdbaddaaed0b0e0c4664f397d
>> Author: Avi Kivity <avi-atKUWr5tajBWk0Htik3J/w@public.gmane.org>
>> Date: Wed Jul 18 12:20:41 2007 +0300
>>
>> Revert "kvm: qemu: initialize ata ports as enabled"
>>
>> This reverts commit 55a3212bc2f5ecddcd4c5cdf2bfb37ad71e45ff2. Turns out
>> it was due to a bad bios and everything works as expectd.
>>
>> Signed-off-by: Avi Kivity <avi-atKUWr5tajBWk0Htik3J/w@public.gmane.org>
>>
>
> I'm not objecting to this change, but I am a little confused. How does
> reverting this fix anything? Are the ports supposed to be on or off?
> If turning them on causes things to slow down, what difference does it
> make who turns them on (bios or qemu)? Sorry if I missed the
> conversation where this was already discussed.
>
>
Good question. I initially guessed that when the bios turns them on, it
does other things as well, but that's not the case.
--
Do not meddle in the internals of kernels, for they are subtle and quick to panic.
-------------------------------------------------------------------------
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/
next prev parent reply other threads:[~2007-07-18 12:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-18 12:31 [kvm-commits] Revert "kvm: qemu: initialize ata ports as enabled" Gregory Haskins
[not found] ` <469DCFDC0200005A00027C77-Igcdv/6uVdMHoYOw/+koYqIwWpluYiW7@public.gmane.org>
2007-07-18 12:42 ` Avi Kivity [this message]
-- strict thread matches above, loose matches on Subject: below --
2007-07-18 12:59 Gregory Haskins
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=469E0AC7.1000903@qumranet.com \
--to=avi-atkuwr5tajbwk0htik3j/w@public.gmane.org \
--cc=ghaskins-Et1tbQHTxzrQT0dZR+AlfA@public.gmane.org \
--cc=kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox