From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [kvm-commits] Revert "kvm: qemu: initialize ata ports as enabled" Date: Wed, 18 Jul 2007 15:42:47 +0300 Message-ID: <469E0AC7.1000903@qumranet.com> References: <469DCFDC0200005A00027C77@mcclure.wal.novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org To: Gregory Haskins Return-path: In-Reply-To: <469DCFDC0200005A00027C77-Igcdv/6uVdMHoYOw/+koYqIwWpluYiW7@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org Errors-To: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: kvm.vger.kernel.org Gregory Haskins wrote: > On Wed, 2007-07-18 at 12:20 +0300, Avi Kivity wrote: > >> repository: /home/avi/kvm >> branch: master >> commit a4d8dd22718d59fbdbaddaaed0b0e0c4664f397d >> Author: Avi Kivity >> Date: Wed Jul 18 12:20:41 2007 +0300 >> >> Revert "kvm: qemu: initialize ata ports as enabled" >> >> This reverts commit 55a3212bc2f5ecddcd4c5cdf2bfb37ad71e45ff2. Turns out >> it was due to a bad bios and everything works as expectd. >> >> Signed-off-by: Avi Kivity >> > > I'm not objecting to this change, but I am a little confused. How does > reverting this fix anything? Are the ports supposed to be on or off? > If turning them on causes things to slow down, what difference does it > make who turns them on (bios or qemu)? Sorry if I missed the > conversation where this was already discussed. > > Good question. I initially guessed that when the bios turns them on, it does other things as well, but that's not the case. -- Do not meddle in the internals of kernels, for they are subtle and quick to panic. ------------------------------------------------------------------------- This SF.net email is sponsored by DB2 Express Download DB2 Express C - the FREE version of DB2 express and take control of your XML. No limits. Just data. Click to get it now. http://sourceforge.net/powerbar/db2/