public inbox for kvm@vger.kernel.org
 help / color / mirror / Atom feed
From: Avi Kivity <avi-atKUWr5tajBWk0Htik3J/w@public.gmane.org>
To: Alan Cox <alan-qBU/x9rampVanCEyBjwyrvXRex20P6io@public.gmane.org>
Cc: kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [RFC] Deferred interrupt handling.
Date: Wed, 18 Jul 2007 19:46:13 +0300	[thread overview]
Message-ID: <469E43D5.70802@qumranet.com> (raw)
In-Reply-To: <20070718174736.0baf6d0e-v58gJUvfdfWUJIigds3554dd74u8MsAO@public.gmane.org>

Alan Cox wrote:
>> What if we will force the specific device to the end of the list. Once
>> IRQ_NONE was returned by the other devices, we will mask the irq,
>> forward the irq to the guest, issue a timer for 1msec. Motivation:
>> 1msec is long enough for the guest to ack the irq + host unmask the irq
>>     
>
> It makes no difference. The deadlock isn't fixable by timing hacks.
> Consider the following sequence
>
>
> 	Guest0	-	blocked on I/O
>
> 	IRQ14 from your hardware
> 		Block IRQ14
> 		Sent to guest (guest is blocked)
>
> 	IRQ14 from hard disk
> 		Ignored (as blocked)
>
> 	Deadlock
>   

IMO the only reasonable solution is to disallow interrupt forwarding
with shared irqs.  If someone later comes up with a bright idea, we can
implement it.  Otherwise the problem will solve itself with hardware
moving to msi.


-- 
Do not meddle in the internals of kernels, for they are subtle and quick to panic.


-------------------------------------------------------------------------
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/

  parent reply	other threads:[~2007-07-18 16:46 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-07-18  9:53 [RFC] Deferred interrupt handling Or Sagi
2007-07-18 11:30 ` Alan Cox
     [not found]   ` <20070718123040.615795b7-v58gJUvfdfWUJIigds3554dd74u8MsAO@public.gmane.org>
2007-07-18 16:36     ` Dor Laor
     [not found]       ` <64F9B87B6B770947A9F8391472E032160CC16C92-yEcIvxbTEBqsx+V+t5oei8rau4O3wl8o3fe8/T/H7NteoWH0uzbU5w@public.gmane.org>
2007-07-18 16:47         ` Alan Cox
     [not found]           ` <20070718174736.0baf6d0e-v58gJUvfdfWUJIigds3554dd74u8MsAO@public.gmane.org>
2007-07-18 16:46             ` Avi Kivity [this message]
     [not found]               ` <469E43D5.70802-atKUWr5tajBWk0Htik3J/w@public.gmane.org>
2007-07-18 16:57                 ` Alan Cox
     [not found]                   ` <20070718175708.6968923e-v58gJUvfdfWUJIigds3554dd74u8MsAO@public.gmane.org>
2007-07-18 16:57                     ` Avi Kivity
     [not found]                       ` <469E4679.205-atKUWr5tajBWk0Htik3J/w@public.gmane.org>
2007-07-18 17:14                         ` Alan Cox
2007-07-18 17:09                 ` Dor Laor
     [not found]                   ` <64F9B87B6B770947A9F8391472E032160CC16D06-yEcIvxbTEBqsx+V+t5oei8rau4O3wl8o3fe8/T/H7NteoWH0uzbU5w@public.gmane.org>
2007-07-18 17:33                     ` Alan Cox
     [not found]                       ` <20070718183358.0a0886aa-v58gJUvfdfWUJIigds3554dd74u8MsAO@public.gmane.org>
2007-07-18 21:29                         ` Dor Laor
     [not found]                           ` <64F9B87B6B770947A9F8391472E032160CC16F3C-yEcIvxbTEBqsx+V+t5oei8rau4O3wl8o3fe8/T/H7NteoWH0uzbU5w@public.gmane.org>
2007-07-18 21:46                             ` Alan Cox
     [not found]                               ` <20070718224649.3e49a978-v58gJUvfdfWUJIigds3554dd74u8MsAO@public.gmane.org>
2007-07-25 14:18                                 ` Pavel Machek
2007-07-18 22:23                             ` Or Sagi
2007-07-18 19:14                 ` Lennart Sorensen
     [not found]                   ` <20070718191433.GB24545-1wCw9BSqJbv44Nm34jS7GywD8/FfD2ys@public.gmane.org>
2007-07-19  9:23                     ` Avi Kivity
     [not found]                       ` <469F2D8C.7020805-atKUWr5tajBWk0Htik3J/w@public.gmane.org>
2007-07-19 13:17                         ` Lennart Sorensen
     [not found]                           ` <20070719131718.GC5623-1wCw9BSqJbv44Nm34jS7GywD8/FfD2ys@public.gmane.org>
2007-07-19 13:38                             ` Avi Kivity
     [not found]                               ` <469F6941.9010901-atKUWr5tajBWk0Htik3J/w@public.gmane.org>
2007-07-19 16:23                                 ` Lennart Sorensen
2007-07-18 15:57 ` Lennart Sorensen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=469E43D5.70802@qumranet.com \
    --to=avi-atkuwr5tajbwk0htik3j/w@public.gmane.org \
    --cc=alan-qBU/x9rampVanCEyBjwyrvXRex20P6io@public.gmane.org \
    --cc=kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox