Re: [PATCH] move structures to svm/vmx.c, use untyped arch_data in independent code

[Avi Kivity <avi-atKUWr5tajBWk0Htik3J/w@public.gmane.org>]

Anthony Liguori wrote:
> Paul Turner wrote:
>   
>> From: Paul Turner <pjt-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
>>
>> Since gcc can't handle [0]-sized arrays without type information we have 
>> to use a generic type and then cast to remove arch dependencies from the 
>> vcpu struct; this patch moves the structures (and the associated 
>> include dependency) from kvm.h into svm/vmx.c as well as introducing 
>> vmx/svm macros for accessing these fields where appt.
>>   
>>     
>
> Sorry, I'm jumping in pretty late in this thread, but this casting stuff 
> seems pretty ugly to me.  Perhaps we need to take the refactoring a 
> little further and have kvm_vcpu be a member of kvm_vcpu_{vmx,svm} and 
> then use the standard container_of() stuff to get at the pointer?
>
>   

This is definitely the right way to do it.


-- 
error compiling committee.c: too many arguments to function


-------------------------------------------------------------------------
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/