Fix bug in unexpected ethernet irq.

Fix bug in unexpected ethernet irq.

[Dong, Eddie]

[-- Attachment #1: Type: text/plain, Size: 1038 bytes --]



    re-deliver level triggreed irq at time of APIC
    EOI will cause some guest no progress and hang in ethernet bringup.
    Temply remove it for future revisit.
    
    Signed-off-by: Yaozu (Eddie) Dong <eddie.dong-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>

diff --git a/drivers/kvm/ioapic.c b/drivers/kvm/ioapic.c
index 6c734db..b4b2d0d 100644
--- a/drivers/kvm/ioapic.c
+++ b/drivers/kvm/ioapic.c
@@ -281,8 +281,18 @@ void kvm_ioapic_update_eoi(struct kvm *kvm, int
vector)
 	ASSERT(ent->fields.trig_mode == IOAPIC_LEVEL_TRIG);
 
 	ent->fields.remote_irr = 0;
+	/*
+	 * TODO:
+	 * qemu ioapic doesn't re-deliver level
+	 * triggered irq at the time of APIC EOI.
+	 * Adding back following code sme time causes RHEL5U
+	 * guest boot no progress at ethernet bringup, so
+	 * leave it same with qemu for now and revisit later.
+	 */
+/*
 	if (!ent->fields.mask && (ioapic->irr & (1 << gsi)))
 		ioapic_deliver(ioapic, gsi);
+*/
 }
 
 static int ioapic_in_range(struct kvm_io_device *this, gpa_t addr)

[-- Attachment #2: irqchip-fix3.patch --]
[-- Type: application/octet-stream, Size: 1069 bytes --]

commit e7bcfccfe5880fafe4dcb4a5038748bde4579aae
Author: root <root@vt32-pae.(none)>
Date:   Fri Jul 20 15:56:14 2007 +0800

    re-deliver level triggreed irq at time of APIC
    EOI will cause some guest no progress.
    Temply remove it for future revisit.
    
    Signed-off-by: Yaozu (Eddie) Dong <eddie.dong@intel.com>

diff --git a/drivers/kvm/ioapic.c b/drivers/kvm/ioapic.c
index 6c734db..b4b2d0d 100644
--- a/drivers/kvm/ioapic.c
+++ b/drivers/kvm/ioapic.c
@@ -281,8 +281,18 @@ void kvm_ioapic_update_eoi(struct kvm *kvm, int vector)
 	ASSERT(ent->fields.trig_mode == IOAPIC_LEVEL_TRIG);
 
 	ent->fields.remote_irr = 0;
+	/*
+	 * TODO:
+	 * qemu ioapic doesn't re-deliver level
+	 * triggered irq at the time of APIC EOI.
+	 * Adding back following code sme time causes RHEL5U
+	 * guest boot no progress at ethernet bringup, so
+	 * leave it same with qemu for now and revisit later.
+	 */
+/*
 	if (!ent->fields.mask && (ioapic->irr & (1 << gsi)))
 		ioapic_deliver(ioapic, gsi);
+*/
 }
 
 static int ioapic_in_range(struct kvm_io_device *this, gpa_t addr)

[-- Attachment #3: Type: text/plain, Size: 228 bytes --]

-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2005.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/

[-- Attachment #4: Type: text/plain, Size: 186 bytes --]

_______________________________________________
kvm-devel mailing list
kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
https://lists.sourceforge.net/lists/listinfo/kvm-devel

Re: Fix bug in unexpected ethernet irq.

[Avi Kivity]

Dong, Eddie wrote:
>     re-deliver level triggreed irq at time of APIC
>     EOI will cause some guest no progress and hang in ethernet bringup.
>     Temply remove it for future revisit.
>     
>     Signed-off-by: Yaozu (Eddie) Dong <eddie.dong-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
>
>   

Applied all three patches and rebased the lapic2 branch against master; 
thanks.

-- 
error compiling committee.c: too many arguments to function


-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems?  Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >>  http://get.splunk.com/