public inbox for kvm@vger.kernel.org
 help / color / mirror / Atom feed
From: Avi Kivity <avi-atKUWr5tajBWk0Htik3J/w@public.gmane.org>
To: Jun Koi <junkoi2004-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: kvm-devel <kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org>
Subject: Re: Dont leak debug flugs in ioctl_get_regs()?
Date: Sun, 22 Jul 2007 13:32:25 +0300	[thread overview]
Message-ID: <46A33239.8010709@qumranet.com> (raw)
In-Reply-To: <fdaac4d50707212305k58ab79bdnf27a2d26dad823c5-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>

Jun Koi wrote:
> Hi,
>
> In kvm_vcpu_ioctl_get_regs() function (kvm_main.c), we have a comment
> like this: "Dont leak debug flags in case they were set for guest
> debugging".
>
> What is the reasons that make us filter out TF and RF bit in EFLAGS like that?
>   

VT and SVM don't virtualize the debug flags.  So when we debug the 
guest, we modify the guest's TF and RF, not some hardware-provided 
shadow register.  So, when we look at the guest's eflags, we need to 
consider that some of the bits are owned by the host, not the guest.

-- 
error compiling committee.c: too many arguments to function


-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems?  Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >>  http://get.splunk.com/

      parent reply	other threads:[~2007-07-22 10:32 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-07-22  6:05 Dont leak debug flugs in ioctl_get_regs()? Jun Koi
     [not found] ` <fdaac4d50707212305k58ab79bdnf27a2d26dad823c5-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2007-07-22 10:32   ` Avi Kivity [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=46A33239.8010709@qumranet.com \
    --to=avi-atkuwr5tajbwk0htik3j/w@public.gmane.org \
    --cc=junkoi2004-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    --cc=kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox