public inbox for kvm@vger.kernel.org
 help / color / mirror / Atom feed
* Dont leak debug flugs in ioctl_get_regs()?
@ 2007-07-22  6:05 Jun Koi
       [not found] ` <fdaac4d50707212305k58ab79bdnf27a2d26dad823c5-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
  0 siblings, 1 reply; 2+ messages in thread
From: Jun Koi @ 2007-07-22  6:05 UTC (permalink / raw)
  To: kvm-devel

Hi,

In kvm_vcpu_ioctl_get_regs() function (kvm_main.c), we have a comment
like this: "Dont leak debug flags in case they were set for guest
debugging".

What is the reasons that make us filter out TF and RF bit in EFLAGS like that?

Thanks,
Jun

-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems?  Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >>  http://get.splunk.com/

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: Dont leak debug flugs in ioctl_get_regs()?
       [not found] ` <fdaac4d50707212305k58ab79bdnf27a2d26dad823c5-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
@ 2007-07-22 10:32   ` Avi Kivity
  0 siblings, 0 replies; 2+ messages in thread
From: Avi Kivity @ 2007-07-22 10:32 UTC (permalink / raw)
  To: Jun Koi; +Cc: kvm-devel

Jun Koi wrote:
> Hi,
>
> In kvm_vcpu_ioctl_get_regs() function (kvm_main.c), we have a comment
> like this: "Dont leak debug flags in case they were set for guest
> debugging".
>
> What is the reasons that make us filter out TF and RF bit in EFLAGS like that?
>   

VT and SVM don't virtualize the debug flags.  So when we debug the 
guest, we modify the guest's TF and RF, not some hardware-provided 
shadow register.  So, when we look at the guest's eflags, we need to 
consider that some of the bits are owned by the host, not the guest.

-- 
error compiling committee.c: too many arguments to function


-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems?  Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >>  http://get.splunk.com/

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2007-07-22 10:32 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-07-22  6:05 Dont leak debug flugs in ioctl_get_regs()? Jun Koi
     [not found] ` <fdaac4d50707212305k58ab79bdnf27a2d26dad823c5-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2007-07-22 10:32   ` Avi Kivity

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox