From mboxrd@z Thu Jan 1 00:00:00 1970 From: Aurelien Jarno Subject: Re: [kvm-commits] kvm: qemu: consume all signals available in order to reduce latency Date: Sun, 22 Jul 2007 15:44:38 +0200 Message-ID: <46A35F46.8040002@aurel32.net> References: <20070722102812.417CB250135@il.qumranet.com> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Cc: kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org To: Avi Kivity Return-path: In-Reply-To: <20070722102812.417CB250135-LjA0eNSCdXrQnzwC+xcbyw@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org Errors-To: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: kvm.vger.kernel.org Avi Kivity a =E9crit : > repository: /home/avi/kvm > branch: master > commit eae5c47eee477f63b55aab2374f702229b697626 > Author: Avi Kivity > Date: Sun Jul 22 13:28:12 2007 +0300 > = > kvm: qemu: consume all signals available in order to reduce latency > = [snip] > } > /* > * we call select() even if no signal was received, to account for > * for which there is no signal handler installed. > */ > + pthread_mutex_unlock(&qemu_mutex); > + cpu_single_env =3D vcpu_env; > main_loop_wait(0); > pthread_mutex_unlock(&qemu_mutex); > } The SMP problems comes from here. The first one should probably be pthread_mutex_lock and not pthread_mutex_unlock. -- = .''`. Aurelien Jarno | GPG: 1024D/F1BCDB73 : :' : Debian developer | Electrical Engineer `. `' aurel32-8fiUuRrzOP0dnm+yROfE0A@public.gmane.org | aurelien-rXXEIb44qovR7s880joybQ@public.gmane.org `- people.debian.org/~aurel32 | www.aurel32.net ------------------------------------------------------------------------- This SF.net email is sponsored by: Splunk Inc. Still grepping through log files to find problems? Stop. Now Search log events and configuration files using AJAX and a browser. Download your FREE copy of Splunk now >> http://get.splunk.com/