From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [kvm-commits] kvm: qemu: consume all signals available in order to reduce latency Date: Sun, 22 Jul 2007 16:52:56 +0300 Message-ID: <46A36138.4000408@qumranet.com> References: <20070722102812.417CB250135@il.qumranet.com> <46A35F46.8040002@aurel32.net> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org To: Aurelien Jarno Return-path: In-Reply-To: <46A35F46.8040002-rXXEIb44qovR7s880joybQ@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org Errors-To: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: kvm.vger.kernel.org Aurelien Jarno wrote: > >> } >> /* >> * we call select() even if no signal was received, to account for >> * for which there is no signal handler installed. >> */ >> + pthread_mutex_unlock(&qemu_mutex); >> + cpu_single_env = vcpu_env; >> main_loop_wait(0); >> pthread_mutex_unlock(&qemu_mutex); >> } >> > > The SMP problems comes from here. The first one should probably be > pthread_mutex_lock and not pthread_mutex_unlock. > > Duh! Thanks for saving me potentially hours of debugging time. Really, someone who's more careful about testing should be doing this thing. -- error compiling committee.c: too many arguments to function ------------------------------------------------------------------------- This SF.net email is sponsored by: Splunk Inc. Still grepping through log files to find problems? Stop. Now Search log events and configuration files using AJAX and a browser. Download your FREE copy of Splunk now >> http://get.splunk.com/