Re: [kvm-commits] kvm: qemu: consume all signals available in order to reduce latency

Avi Kivity
2007-07-22T13:52:56Z

Aurelien Jarno wrote:
>
>> }
>> /*
>> * we call select() even if no signal was received, to account for
>> * for which there is no signal handler installed.
>> */
>> + pthread_mutex_unlock(&qemu_mutex);
>> + cpu_single_env = vcpu_env;
>> main_loop_wait(0);
>> pthread_mutex_unlock(&qemu_mutex);
>> }
>>
>
> The SMP problems comes from here. The first one should probably be
> pthread_mutex_lock and not pthread_mutex_unlock.
>
>

Duh! Thanks for saving me potentially hours of debugging time.

Really, someone who's more careful about testing should be doing this thing.

--
error compiling committee.c: too many arguments to function

-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems? Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >> http://get.splunk.com/