Re: [kvm-commits] kvm: qemu: consume all signals available in order to reduce latency

Aurelien Jarno
2007-07-22T13:44:38Z

Avi Kivity a écrit :
> repository: /home/avi/kvm
> branch: master
> commit eae5c47eee477f63b55aab2374f702229b697626
> Author: Avi Kivity <avi-atKUWr5tajBWk0Htik3J/w@public.gmane.org>
> Date: Sun Jul 22 13:28:12 2007 +0300
>
> kvm: qemu: consume all signals available in order to reduce latency
>

[snip]

> }
> /*
> * we call select() even if no signal was received, to account for
> * for which there is no signal handler installed.
> */
> + pthread_mutex_unlock(&qemu_mutex);
> + cpu_single_env = vcpu_env;
> main_loop_wait(0);
> pthread_mutex_unlock(&qemu_mutex);
> }

The SMP problems comes from here. The first one should probably be
pthread_mutex_lock and not pthread_mutex_unlock.

--
.''`. Aurelien Jarno | GPG: 1024D/F1BCDB73
: :' : Debian developer | Electrical Engineer
`. `' aurel32-8fiUuRrzOP0dnm+yROfE0A@public.gmane.org | aurelien-rXXEIb44qovR7s880joybQ@public.gmane.org
`- people.debian.org/~aurel32 | www.aurel32.net

-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems? Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >> http://get.splunk.com/