[patch] Make sure that we compile before installing

[patch] Make sure that we compile before installing

[Nguyen Anh Quynh]

[-- Attachment #1: Type: text/plain, Size: 155 bytes --]

This patch makes "install" compile code, and "install-rpm" package rpms.

Signed-off-by: Nguyen Anh Quynh <aquynh-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>

[-- Attachment #2: patch18.patch --]
[-- Type: text/x-patch, Size: 626 bytes --]

diff --git a/Makefile b/Makefile
index 37b01d2..dd3f51c 100644
--- a/Makefile
+++ b/Makefile
@@ -22,7 +22,7 @@ initdir = /etc/init.d
 confdir = /etc/kvm
 utilsdir = /etc/kvm/utils
 
-install-rpm:
+install-rpm: rpm
 	mkdir -p $(DESTDIR)/$(bindir)
 	mkdir -p $(DESTDIR)/$(confdir)
 	mkdir -p $(DESTDIR)/$(initdir)
@@ -35,7 +35,7 @@ install-rpm:
 	cp scripts/qemu-ifup $(DESTDIR)/$(confdir)/qemu-ifup
 	install -t $(DESTDIR)/etc/udev/rules.d scripts/*kvm*.rules
 
-install:
+install: all
 	$(kcmd)make -C kernel DESTDIR="$(DESTDIR)" install
 	make -C user DESTDIR="$(DESTDIR)" install
 	make -C qemu DESTDIR="$(DESTDIR)" install

[-- Attachment #3: Type: text/plain, Size: 315 bytes --]

-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems?  Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >>  http://get.splunk.com/

[-- Attachment #4: Type: text/plain, Size: 186 bytes --]

_______________________________________________
kvm-devel mailing list
kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
https://lists.sourceforge.net/lists/listinfo/kvm-devel

Re: [patch] Make sure that we compile before installing

[Avi Kivity]

Nguyen Anh Quynh wrote:
> This patch makes "install" compile code, and "install-rpm" package rpms.

'install' and 'install-rpm' are typically run as root, and we don't want 
to compile as root.


-- 
error compiling committee.c: too many arguments to function


-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems?  Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >>  http://get.splunk.com/

Re: [patch] Make sure that we compile before installing

[Nguyen Anh Quynh]

On 7/23/07, Avi Kivity <avi-atKUWr5tajBWk0Htik3J/w@public.gmane.org> wrote:
> Nguyen Anh Quynh wrote:
> > This patch makes "install" compile code, and "install-rpm" package rpms.
>
> 'install' and 'install-rpm' are typically run as root, and we don't want
> to compile as root.

Is it because of security reason, or something else?

I want this patch because without it, sometimes I install without
recompiling. As a result, the old binary is installed, and I dont
notice that I dont run the code with new change. That really confuses,
and even took me a while to figure out what actually happend.

-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems?  Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >>  http://get.splunk.com/

Re: [patch] Make sure that we compile before installing

[Avi Kivity]

Nguyen Anh Quynh wrote:
> On 7/23/07, Avi Kivity <avi-atKUWr5tajBWk0Htik3J/w@public.gmane.org> wrote:
>> Nguyen Anh Quynh wrote:
>> > This patch makes "install" compile code, and "install-rpm" package 
>> rpms.
>>
>> 'install' and 'install-rpm' are typically run as root, and we don't want
>> to compile as root.
>
> Is it because of security reason, or something else?
>

Just standard practice.  For example, my home directory is nfs mounted, 
so I can't compile as root.  Since I sometimes test before committing, 
I'd like to keep the ability to compile.

> I want this patch because without it, sometimes I install without
> recompiling. As a result, the old binary is installed, and I dont
> notice that I dont run the code with new change. That really confuses,
> and even took me a while to figure out what actually happend.

Run 'make && make install' (or a script that does that) instead.

-- 
error compiling committee.c: too many arguments to function


-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems?  Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >>  http://get.splunk.com/