From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [patch] Make sure that we compile before installing Date: Mon, 23 Jul 2007 12:15:58 +0300 Message-ID: <46A471CE.3010004@qumranet.com> References: <9cde8bff0707230149x5cf686cbh45f68ce30a82c87f@mail.gmail.com> <46A46F3F.1020802@qumranet.com> <9cde8bff0707230212y15855939q32c61d9a4cffc4c2@mail.gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org To: Nguyen Anh Quynh Return-path: In-Reply-To: <9cde8bff0707230212y15855939q32c61d9a4cffc4c2-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org Errors-To: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: kvm.vger.kernel.org Nguyen Anh Quynh wrote: > On 7/23/07, Avi Kivity wrote: >> Nguyen Anh Quynh wrote: >> > This patch makes "install" compile code, and "install-rpm" package >> rpms. >> >> 'install' and 'install-rpm' are typically run as root, and we don't want >> to compile as root. > > Is it because of security reason, or something else? > Just standard practice. For example, my home directory is nfs mounted, so I can't compile as root. Since I sometimes test before committing, I'd like to keep the ability to compile. > I want this patch because without it, sometimes I install without > recompiling. As a result, the old binary is installed, and I dont > notice that I dont run the code with new change. That really confuses, > and even took me a while to figure out what actually happend. Run 'make && make install' (or a script that does that) instead. -- error compiling committee.c: too many arguments to function ------------------------------------------------------------------------- This SF.net email is sponsored by: Splunk Inc. Still grepping through log files to find problems? Stop. Now Search log events and configuration files using AJAX and a browser. Download your FREE copy of Splunk now >> http://get.splunk.com/