From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [RFC 7/8]KVM: swap out guest pages Date: Tue, 24 Jul 2007 08:38:51 +0300 Message-ID: <46A5906B.6080301@qumranet.com> References: <1185173505.2645.71.camel@sli10-conroe.sh.intel.com> <46A491C4.8010302@qumranet.com> <1185241908.24201.22.camel@sli10-conroe.sh.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: kvm-devel , lkml To: Shaohua Li Return-path: In-Reply-To: <1185241908.24201.22.camel-yAZKuqJtXNMXR+D7ky4Foa2pdiUAq4bhAL8bYrjMMd8@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org Errors-To: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: kvm.vger.kernel.org Shaohua Li wrote: >>> >>> >> You're not removing any shadows of the page, in case that page is a >> guest page table. But I don't see anything wrong with it -- the page >> won't change while it's in swap. >> > You are right. Should we? > I don't think so. It's just strange to have shadows for a guest page that is swapped out, so I pointed that out. But as the page cannot change in swap, everything is safe. I guess that kernel page tables could be swapped out after a short while in a guest that doesn't swap its own kernel pages. -- Do not meddle in the internals of kernels, for they are subtle and quick to panic. ------------------------------------------------------------------------- This SF.net email is sponsored by: Splunk Inc. Still grepping through log files to find problems? Stop. Now Search log events and configuration files using AJAX and a browser. Download your FREE copy of Splunk now >> http://get.splunk.com/