Reverting back in lapic2 branch of kvm-userspace?

Reverting back in lapic2 branch of kvm-userspace?

[He, Qing]

Avi/Eddie,
	I just noticed that the latest commit in lapic2 branch of
kvm-userspace effectively disabled in-kernel apic and ioapic. I don't
suppose it's intended, is it?

Thanks,
Qing

-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems?  Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >>  http://get.splunk.com/

Re: Reverting back in lapic2 branch of kvm-userspace?

[Avi Kivity]

He, Qing wrote:
> Avi/Eddie,
> 	I just noticed that the latest commit in lapic2 branch of
> kvm-userspace effectively disabled in-kernel apic and ioapic. I don't
> suppose it's intended, is it?
>
>   

It was a mistake on my part.  I re-did the commit and pushed a new
version (you need to fetch with +lapic2).

Eddie, hopefully there aren't more mistakes like that, can you check?


-- 
Do not meddle in the internals of kernels, for they are subtle and quick to panic.


-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems?  Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >>  http://get.splunk.com/

Re: Reverting back in lapic2 branch of kvm-userspace?

[Dong, Eddie]

???
I didn't think the APIC is removed.
Who and which commit?
Eddie

Avi Kivity wrote:
> He, Qing wrote:
>> Avi/Eddie,
>> 	I just noticed that the latest commit in lapic2 branch of
>> kvm-userspace effectively disabled in-kernel apic and ioapic. I
>> don't suppose it's intended, is it? 
>> 
>> 
> 
> It was a mistake on my part.  I re-did the commit and pushed a new
> version (you need to fetch with +lapic2).
> 
> Eddie, hopefully there aren't more mistakes like that, can you check?
> 
> 
> --
> Do not meddle in the internals of kernels, for they are subtle
> and quick to panic.

-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems?  Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >>  http://get.splunk.com/

Re: Reverting back in lapic2 branch of kvm-userspace?

[Avi Kivity]

Dong, Eddie wrote:
> ???
> I didn't think the APIC is removed.
> Who and which commit?
>   

commit 394b6efba95f21d22687743def9aa1a0b7125809
Author: Eddie Dong <eddie.dong-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Date:   Thu Jul 19 12:12:53 2007 +0300

    kvm: rename KVM_CAP_PIC to KVM_CAP_IRQCHIP

had parts of the patch that removed the apic capability bit from cpuid. 
I redid that commit, but I may have made more mistakes earlier.


> Eddie
>
> Avi Kivity wrote:
>   
>> He, Qing wrote:
>>     
>>> Avi/Eddie,
>>> 	I just noticed that the latest commit in lapic2 branch of
>>> kvm-userspace effectively disabled in-kernel apic and ioapic. I
>>> don't suppose it's intended, is it? 
>>>
>>>
>>>       
>> It was a mistake on my part.  I re-did the commit and pushed a new
>> version (you need to fetch with +lapic2).
>>
>> Eddie, hopefully there aren't more mistakes like that, can you check?
>>
>>
>> --
>> Do not meddle in the internals of kernels, for they are subtle
>> and quick to panic.
>>     


-- 
Do not meddle in the internals of kernels, for they are subtle and quick to panic.


-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems?  Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >>  http://get.splunk.com/

Re: Reverting back in lapic2 branch of kvm-userspace?

[Dong, Eddie]

O, I checked minutes ago (using local mirror), everthing is fine. 
I got live migration works for FC5_32 which uses PIC only.

Eddie

-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems?  Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >>  http://get.splunk.com/