From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: Reverting back in lapic2 branch of kvm-userspace? Date: Tue, 24 Jul 2007 09:02:56 +0300 Message-ID: <46A59610.7080206@qumranet.com> References: <10EA09EFD8728347A513008B6B0DA77A01D15BBE@pdsmsx411.ccr.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: kvm-devel , "He, Qing" To: "Dong, Eddie" Return-path: In-Reply-To: <10EA09EFD8728347A513008B6B0DA77A01D15BBE-wq7ZOvIWXbNpB2pF5aRoyrfspsVTdybXVpNB7YpNyf8@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org Errors-To: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: kvm.vger.kernel.org Dong, Eddie wrote: > ??? > I didn't think the APIC is removed. > Who and which commit? > commit 394b6efba95f21d22687743def9aa1a0b7125809 Author: Eddie Dong Date: Thu Jul 19 12:12:53 2007 +0300 kvm: rename KVM_CAP_PIC to KVM_CAP_IRQCHIP had parts of the patch that removed the apic capability bit from cpuid. I redid that commit, but I may have made more mistakes earlier. > Eddie > > Avi Kivity wrote: > >> He, Qing wrote: >> >>> Avi/Eddie, >>> I just noticed that the latest commit in lapic2 branch of >>> kvm-userspace effectively disabled in-kernel apic and ioapic. I >>> don't suppose it's intended, is it? >>> >>> >>> >> It was a mistake on my part. I re-did the commit and pushed a new >> version (you need to fetch with +lapic2). >> >> Eddie, hopefully there aren't more mistakes like that, can you check? >> >> >> -- >> Do not meddle in the internals of kernels, for they are subtle >> and quick to panic. >> -- Do not meddle in the internals of kernels, for they are subtle and quick to panic. ------------------------------------------------------------------------- This SF.net email is sponsored by: Splunk Inc. Still grepping through log files to find problems? Stop. Now Search log events and configuration files using AJAX and a browser. Download your FREE copy of Splunk now >> http://get.splunk.com/