From: Avi Kivity <avi-atKUWr5tajBWk0Htik3J/w@public.gmane.org>
To: "Dong, Eddie" <eddie.dong-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Cc: kvm-devel <kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org>
Subject: Re: preclean up for live migration
Date: Tue, 24 Jul 2007 12:42:22 +0300 [thread overview]
Message-ID: <46A5C97E.80706@qumranet.com> (raw)
In-Reply-To: <10EA09EFD8728347A513008B6B0DA77A01D15B93-wq7ZOvIWXbNpB2pF5aRoyrfspsVTdybXVpNB7YpNyf8@public.gmane.org>
Dong, Eddie wrote:
> Against lapic2
>
> This is a pre-cleanup for in kernel irqchip live migration support.
> A guest may not have APIC but still have apic_base_msr be
> save/restored in current live migration framework.
>
>
> Signed-off-by: Yaozu (Eddie) Dong <eddie.dong-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
>
> diff --git a/drivers/kvm/i8259.c b/drivers/kvm/i8259.c
> diff --git a/drivers/kvm/irq.h b/drivers/kvm/irq.h
> index a74d2e9..6cfc19f 100644
> --- a/drivers/kvm/irq.h
> +++ b/drivers/kvm/irq.h
> @@ -106,7 +106,6 @@ struct kvm_ioapic {
> struct kvm_lapic {
> spinlock_t lock; /* TODO for revise */
> u32 status;
> - u64 base_msr;
> unsigned long base_address;
> struct kvm_io_device dev;
> struct {
> diff --git a/drivers/kvm/kvm.h b/drivers/kvm/kvm.h
> index d7e16ba..e62ecf2 100644
> --- a/drivers/kvm/kvm.h
> +++ b/drivers/kvm/kvm.h
> @@ -336,6 +336,7 @@ struct kvm_vcpu {
> unsigned long cr4;
> u64 pdptrs[4]; /* pae */
> u64 shadow_efer;
> + u64 apic_base_msr;
>
Can we keep the name the same? Then this patch simply undoes some of
the main lapic patch and we can fold them together.
--
error compiling committee.c: too many arguments to function
-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems? Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >> http://get.splunk.com/
next prev parent reply other threads:[~2007-07-24 9:42 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-24 5:38 preclean up for live migration Dong, Eddie
[not found] ` <10EA09EFD8728347A513008B6B0DA77A01D15B93-wq7ZOvIWXbNpB2pF5aRoyrfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2007-07-24 9:42 ` Avi Kivity [this message]
[not found] ` <46A5C97E.80706-atKUWr5tajBWk0Htik3J/w@public.gmane.org>
2007-08-01 15:10 ` Dong, Eddie
[not found] ` <10EA09EFD8728347A513008B6B0DA77A01DB6D3B-wq7ZOvIWXbNpB2pF5aRoyrfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2007-08-01 18:27 ` Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46A5C97E.80706@qumranet.com \
--to=avi-atkuwr5tajbwk0htik3j/w@public.gmane.org \
--cc=eddie.dong-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
--cc=kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox