From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: preclean up for live migration Date: Tue, 24 Jul 2007 12:42:22 +0300 Message-ID: <46A5C97E.80706@qumranet.com> References: <10EA09EFD8728347A513008B6B0DA77A01D15B93@pdsmsx411.ccr.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: kvm-devel To: "Dong, Eddie" Return-path: In-Reply-To: <10EA09EFD8728347A513008B6B0DA77A01D15B93-wq7ZOvIWXbNpB2pF5aRoyrfspsVTdybXVpNB7YpNyf8@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org Errors-To: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: kvm.vger.kernel.org Dong, Eddie wrote: > Against lapic2 > > This is a pre-cleanup for in kernel irqchip live migration support. > A guest may not have APIC but still have apic_base_msr be > save/restored in current live migration framework. > > > Signed-off-by: Yaozu (Eddie) Dong > > diff --git a/drivers/kvm/i8259.c b/drivers/kvm/i8259.c > diff --git a/drivers/kvm/irq.h b/drivers/kvm/irq.h > index a74d2e9..6cfc19f 100644 > --- a/drivers/kvm/irq.h > +++ b/drivers/kvm/irq.h > @@ -106,7 +106,6 @@ struct kvm_ioapic { > struct kvm_lapic { > spinlock_t lock; /* TODO for revise */ > u32 status; > - u64 base_msr; > unsigned long base_address; > struct kvm_io_device dev; > struct { > diff --git a/drivers/kvm/kvm.h b/drivers/kvm/kvm.h > index d7e16ba..e62ecf2 100644 > --- a/drivers/kvm/kvm.h > +++ b/drivers/kvm/kvm.h > @@ -336,6 +336,7 @@ struct kvm_vcpu { > unsigned long cr4; > u64 pdptrs[4]; /* pae */ > u64 shadow_efer; > + u64 apic_base_msr; > Can we keep the name the same? Then this patch simply undoes some of the main lapic patch and we can fold them together. -- error compiling committee.c: too many arguments to function ------------------------------------------------------------------------- This SF.net email is sponsored by: Splunk Inc. Still grepping through log files to find problems? Stop. Now Search log events and configuration files using AJAX and a browser. Download your FREE copy of Splunk now >> http://get.splunk.com/