[patch] mmu.c: remove unused functions

[patch] mmu.c: remove unused functions

[Nguyen Anh Quynh]

[-- Attachment #1: Type: text/plain, Size: 132 bytes --]

This patch removes some unused functions in mmu.c

Signed-off-by: Nguyen Anh Quynh <aquynh-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: patch19.patch --]
[-- Type: text/x-patch; name="patch19.patch", Size: 884 bytes --]

diff --git a/drivers/kvm/mmu.c b/drivers/kvm/mmu.c
index a7985b1..13fb6bb 100644
--- a/drivers/kvm/mmu.c
+++ b/drivers/kvm/mmu.c
@@ -156,21 +156,6 @@ static struct kmem_cache *pte_chain_cache;
 static struct kmem_cache *rmap_desc_cache;
 static struct kmem_cache *mmu_page_header_cache;
 
-static int is_write_protection(struct kvm_vcpu *vcpu)
-{
-	return vcpu->cr0 & X86_CR0_WP;
-}
-
-static int is_cpuid_PSE36(void)
-{
-	return 1;
-}
-
-static int is_nx(struct kvm_vcpu *vcpu)
-{
-	return vcpu->shadow_efer & EFER_NX;
-}
-
 static int is_present_pte(unsigned long pte)
 {
 	return pte & PT_PRESENT_MASK;
@@ -181,11 +166,6 @@ static int is_writeble_pte(unsigned long pte)
 	return pte & PT_WRITABLE_MASK;
 }
 
-static int is_io_pte(unsigned long pte)
-{
-	return pte & PT_SHADOW_IO_MARK;
-}
-
 static int is_rmap_pte(u64 pte)
 {
 	return (pte & (PT_WRITABLE_MASK | PT_PRESENT_MASK))

[-- Attachment #3: Type: text/plain, Size: 315 bytes --]

-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems?  Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >>  http://get.splunk.com/

[-- Attachment #4: Type: text/plain, Size: 186 bytes --]

_______________________________________________
kvm-devel mailing list
kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
https://lists.sourceforge.net/lists/listinfo/kvm-devel

Re: [patch] mmu.c: remove unused functions

[Avi Kivity]

Nguyen Anh Quynh wrote:
> This patch removes some unused functions in mmu.c

> -static int is_nx(struct kvm_vcpu *vcpu)
> -{
> -	return vcpu->shadow_efer & EFER_NX;
> -}
> -

is_nx() for example, is used.

More care, please.


-- 
error compiling committee.c: too many arguments to function


-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems?  Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >>  http://get.splunk.com/

Re: [patch] mmu.c: remove unused functions

[Nguyen Anh Quynh]

On 7/24/07, Avi Kivity <avi-atKUWr5tajBWk0Htik3J/w@public.gmane.org> wrote:
> Nguyen Anh Quynh wrote:
> > This patch removes some unused functions in mmu.c
>
> > -static int is_nx(struct kvm_vcpu *vcpu)
> > -{
> > -     return vcpu->shadow_efer & EFER_NX;
> > -}
> > -
>
> is_nx() for example, is used.
>
> More care, please.

Oops, I looked again. The way we handle static functions with
paging_tmpl.h is weird.

How about moving these functions there?

-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems?  Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >>  http://get.splunk.com/

Re: [patch] mmu.c: remove unused functions

[Avi Kivity]

Nguyen Anh Quynh wrote:
> On 7/24/07, Avi Kivity <avi-atKUWr5tajBWk0Htik3J/w@public.gmane.org> wrote:
>> Nguyen Anh Quynh wrote:
>> > This patch removes some unused functions in mmu.c
>>
>> > -static int is_nx(struct kvm_vcpu *vcpu)
>> > -{
>> > -     return vcpu->shadow_efer & EFER_NX;
>> > -}
>> > -
>>
>> is_nx() for example, is used.
>>
>> More care, please.
>
> Oops, I looked again. The way we handle static functions with
> paging_tmpl.h is weird.
>
> How about moving these functions there?

It's wierder than you think.  You'll get multiple definition errors.

-- 
Do not meddle in the internals of kernels, for they are subtle and quick to panic.


-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems?  Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >>  http://get.splunk.com/

Re: [patch] mmu.c: remove unused functions

[Nguyen Anh Quynh]

On 7/25/07, Avi Kivity <avi-atKUWr5tajBWk0Htik3J/w@public.gmane.org> wrote:
> Nguyen Anh Quynh wrote:
> > On 7/24/07, Avi Kivity <avi-atKUWr5tajBWk0Htik3J/w@public.gmane.org> wrote:
> >> Nguyen Anh Quynh wrote:
> >> > This patch removes some unused functions in mmu.c
> >>
> >> > -static int is_nx(struct kvm_vcpu *vcpu)
> >> > -{
> >> > -     return vcpu->shadow_efer & EFER_NX;
> >> > -}
> >> > -
> >>
> >> is_nx() for example, is used.
> >>
> >> More care, please.
> >
> > Oops, I looked again. The way we handle static functions with
> > paging_tmpl.h is weird.
> >
> > How about moving these functions there?
>
> It's wierder than you think.  You'll get multiple definition errors.

Most of the time that can be solved with some #ifdef. And I dont see
#ifdef in paging_tmpl.h

But never mind if you dont see that is worth fixing.

-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems?  Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >>  http://get.splunk.com/