From: Avi Kivity <avi-atKUWr5tajBWk0Htik3J/w@public.gmane.org>
To: Nguyen Anh Quynh <aquynh-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
Subject: Re: [patch] mmu.c: remove unused functions
Date: Wed, 25 Jul 2007 06:08:46 +0300 [thread overview]
Message-ID: <46A6BEBE.9030402@qumranet.com> (raw)
In-Reply-To: <9cde8bff0707241925nd2dea95t737af154b1da7108-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
Nguyen Anh Quynh wrote:
> On 7/24/07, Avi Kivity <avi-atKUWr5tajBWk0Htik3J/w@public.gmane.org> wrote:
>> Nguyen Anh Quynh wrote:
>> > This patch removes some unused functions in mmu.c
>>
>> > -static int is_nx(struct kvm_vcpu *vcpu)
>> > -{
>> > - return vcpu->shadow_efer & EFER_NX;
>> > -}
>> > -
>>
>> is_nx() for example, is used.
>>
>> More care, please.
>
> Oops, I looked again. The way we handle static functions with
> paging_tmpl.h is weird.
>
> How about moving these functions there?
It's wierder than you think. You'll get multiple definition errors.
--
Do not meddle in the internals of kernels, for they are subtle and quick to panic.
-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems? Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >> http://get.splunk.com/
next prev parent reply other threads:[~2007-07-25 3:08 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-24 10:49 [patch] mmu.c: remove unused functions Nguyen Anh Quynh
[not found] ` <9cde8bff0707240349t70e72611n35e608d7848f08f7-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2007-07-24 10:55 ` Avi Kivity
[not found] ` <46A5DAB5.7020503-atKUWr5tajBWk0Htik3J/w@public.gmane.org>
2007-07-25 2:25 ` Nguyen Anh Quynh
[not found] ` <9cde8bff0707241925nd2dea95t737af154b1da7108-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2007-07-25 3:08 ` Avi Kivity [this message]
[not found] ` <46A6BEBE.9030402-atKUWr5tajBWk0Htik3J/w@public.gmane.org>
2007-07-25 3:19 ` Nguyen Anh Quynh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46A6BEBE.9030402@qumranet.com \
--to=avi-atkuwr5tajbwk0htik3j/w@public.gmane.org \
--cc=aquynh-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox