From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [patch] mmu.c: remove unused functions Date: Wed, 25 Jul 2007 06:08:46 +0300 Message-ID: <46A6BEBE.9030402@qumranet.com> References: <9cde8bff0707240349t70e72611n35e608d7848f08f7@mail.gmail.com> <46A5DAB5.7020503@qumranet.com> <9cde8bff0707241925nd2dea95t737af154b1da7108@mail.gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org To: Nguyen Anh Quynh Return-path: In-Reply-To: <9cde8bff0707241925nd2dea95t737af154b1da7108-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org Errors-To: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: kvm.vger.kernel.org Nguyen Anh Quynh wrote: > On 7/24/07, Avi Kivity wrote: >> Nguyen Anh Quynh wrote: >> > This patch removes some unused functions in mmu.c >> >> > -static int is_nx(struct kvm_vcpu *vcpu) >> > -{ >> > - return vcpu->shadow_efer & EFER_NX; >> > -} >> > - >> >> is_nx() for example, is used. >> >> More care, please. > > Oops, I looked again. The way we handle static functions with > paging_tmpl.h is weird. > > How about moving these functions there? It's wierder than you think. You'll get multiple definition errors. -- Do not meddle in the internals of kernels, for they are subtle and quick to panic. ------------------------------------------------------------------------- This SF.net email is sponsored by: Splunk Inc. Still grepping through log files to find problems? Stop. Now Search log events and configuration files using AJAX and a browser. Download your FREE copy of Splunk now >> http://get.splunk.com/