public inbox for kvm@vger.kernel.org
 help / color / mirror / Atom feed
From: Avi Kivity <avi-atKUWr5tajBWk0Htik3J/w@public.gmane.org>
To: Gregory Haskins <ghaskins-Et1tbQHTxzrQT0dZR+AlfA@public.gmane.org>
Cc: kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
Subject: Re: [PATCH] KVM: VMX cannot yet handle	migration-after-preemption, so disable it
Date: Wed, 25 Jul 2007 06:20:30 +0300	[thread overview]
Message-ID: <46A6C17E.9030307@qumranet.com> (raw)
In-Reply-To: <20070724204022.5456.72025.stgit-sLgBBP33vUGnsjUZhwzVf9HuzzzSOjJt@public.gmane.org>

Gregory Haskins wrote:
> This patch applies to the preempt-hooks branch to enable KVM to function
> properly on VMX.  With preemption enabled, the KVM context can get scheduled
> out at arbitrary points.  The preempt-hooks allow us to correctly restore
> the host state while being preemptible, but preemption causes problems on the
> schedule-in side if the vcpu-task migrates to a new pCPU.
>
> Ideally we can handle the migration scenario better (patch for this in
> progress).  However, this patch provides correctness in the interim at the
> expense of a small amount of flexibility. E.g. we can only migrate when the
> vcpu_lock is not held.
>
>   

I'd rather wait for the real fix, especially as this is an experimental
branch.  Can you provide details of the issue?

-- 
Do not meddle in the internals of kernels, for they are subtle and quick to panic.


-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems?  Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >>  http://get.splunk.com/

  parent reply	other threads:[~2007-07-25  3:20 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-07-24 20:47 [PATCH] KVM: VMX cannot yet handle migration-after-preemption, so disable it Gregory Haskins
     [not found] ` <20070724204022.5456.72025.stgit-sLgBBP33vUGnsjUZhwzVf9HuzzzSOjJt@public.gmane.org>
2007-07-25  3:20   ` Avi Kivity [this message]
  -- strict thread matches above, loose matches on Subject: below --
2007-07-25  4:10 Gregory Haskins
     [not found] ` <46A694EC0200005A000281E3-Igcdv/6uVdMHoYOw/+koYqIwWpluYiW7@public.gmane.org>
2007-07-25  4:13   ` Avi Kivity
2007-07-25  4:22 Gregory Haskins

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=46A6C17E.9030307@qumranet.com \
    --to=avi-atkuwr5tajbwk0htik3j/w@public.gmane.org \
    --cc=ghaskins-Et1tbQHTxzrQT0dZR+AlfA@public.gmane.org \
    --cc=kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox