From: Avi Kivity <avi-atKUWr5tajBWk0Htik3J/w@public.gmane.org>
To: "He, Qing" <qing.he-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Cc: kvm-devel <kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org>
Subject: Re: [PATCH 2/3] add get/set irqchip ioctls for in kernel PIC live migration support
Date: Thu, 26 Jul 2007 08:09:34 +0300 [thread overview]
Message-ID: <46A82C8E.1060102@qumranet.com> (raw)
In-Reply-To: <37E52D09333DE2469A03574C88DBF40F048EAE-wq7ZOvIWXbM/UvCtAeCM4rfspsVTdybXVpNB7YpNyf8@public.gmane.org>
[-- Attachment #1: Type: text/plain, Size: 560 bytes --]
He, Qing wrote:
>
>>> + union {
>>> + struct kvm_ioctl_pic pic;
>>>
>>>
>> Reserve some space here so that other members can be added to the union
>> without changing the ioctl number.
>>
>
> I checked the kvm_ioapic structure, if IOAPIC_NUM_PINS==24, at least 216 bytes is required (within the union). If reserving space is for possible future expansion, how much space do you think is appropriate?
>
>
Well, round up and double we get 512.
--
Do not meddle in the internals of kernels, for they are subtle and quick to panic.
[-- Attachment #2: Type: text/plain, Size: 315 bytes --]
-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems? Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >> http://get.splunk.com/
[-- Attachment #3: Type: text/plain, Size: 186 bytes --]
_______________________________________________
kvm-devel mailing list
kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
https://lists.sourceforge.net/lists/listinfo/kvm-devel
next prev parent reply other threads:[~2007-07-26 5:09 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-25 10:09 [PATCH 2/3] add get/set irqchip ioctls for in kernel PIC live migration support He, Qing
[not found] ` <37E52D09333DE2469A03574C88DBF40F048EA9-wq7ZOvIWXbM/UvCtAeCM4rfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2007-07-25 11:21 ` Avi Kivity
[not found] ` <46A7323C.4010308-atKUWr5tajBWk0Htik3J/w@public.gmane.org>
2007-07-26 3:15 ` He, Qing
[not found] ` <37E52D09333DE2469A03574C88DBF40F048EAE-wq7ZOvIWXbM/UvCtAeCM4rfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2007-07-26 5:09 ` Avi Kivity [this message]
2007-07-26 5:43 ` He, Qing
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46A82C8E.1060102@qumranet.com \
--to=avi-atkuwr5tajbwk0htik3j/w@public.gmane.org \
--cc=kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
--cc=qing.he-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox