Re: [PATCH]Abstract vmcs feature detect part

[Avi Kivity <avi-atKUWr5tajBWk0Htik3J/w@public.gmane.org>]

[-- Attachment #1: Type: text/plain, Size: 1659 bytes --]

Yang, Sheng wrote:
> Sorry for not explain clearly.
>
> This patch replaces vmcs_write32_fixedbits() with adjust_vmx_controls(),

It still doesn't say why, but I can now see it: this is code from Xen. I
have no objection to copying Xen code, but it needs to be documented in
the changelog, and there needs to be a good reason as to why you're
replacing existing code rather than improving it. So far I don't see
this reason.

>  and add some relevant fields to vmcs_config for the global using. 
>
> Put vmcs situation in global variable enables us using it to check current vmcs condition and deal with different types of CPU, for we may add some feature which is not supported by all types of CPU. And adjust_vmx_controls() also offers a optional(all filled by 0 now, but will be extended after) feature test . In the future, we can decide how VMCS would be filled by detecting CPU's capability in setup_vmcs_config(). 
>
> I attached modified patch. If you need more information, please let me know.
>
>   

Please either use git send-email or paste patches as well as attaching
them so others can review too.

> Index: kvm/drivers/kvm/vmx.c
> ===================================================================
> --- kvm.orig/drivers/kvm/vmx.c 2007-07-25 16:41:38.000000000 +0800
> +++ kvm/drivers/kvm/vmx.c 2007-07-26 13:24:59.000000000 +0800
> @@ -47,11 +47,15 @@
> #endif
> #define EFER_SAVE_RESTORE_BITS ((u64)EFER_SCE)
>
> -static struct vmcs_descriptor {
> +static struct vmcs_config {

Why the name change? Just for Xen compatibility? If that's the only
reason, it's insufficent.


-- 
error compiling committee.c: too many arguments to function



[-- Attachment #2: Type: text/plain, Size: 315 bytes --]

-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems?  Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >>  http://get.splunk.com/

[-- Attachment #3: Type: text/plain, Size: 186 bytes --]

_______________________________________________
kvm-devel mailing list
kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
https://lists.sourceforge.net/lists/listinfo/kvm-devel