From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH]Abstract vmcs feature detect part Date: Thu, 26 Jul 2007 12:50:20 +0300 Message-ID: <46A86E5C.9000106@qumranet.com> References: <46A85A35.7040902@qumranet.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org To: "Li, Xin B" Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org Errors-To: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: kvm.vger.kernel.org Li, Xin B wrote: >>> This patch replaces vmcs_write32_fixedbits() with >>> >> adjust_vmx_controls(), >> >> It still doesn't say why, but I can now see it: this is code >> > >from Xen. I have no objection to copying Xen code, but it needs to be > documented in > >> the changelog, and there needs to be a good reason as to why you're >> replacing existing code rather than improving it. So far I don't see >> this reason >> > > We want to enable MSR BITMAP and VTPR for VMX guest, which depend on > this, I think you're already aware this. > And another reason is, all physical CPUs on the system should support > the _same_ VMX features set, or obviously it's weird that one CPU > support Intel VTPR feature while some other not. This is a rare case, > but basically we should detect it when KVM is being initialized, and > this patch also helps. > > Sure. Please update the changelog to state this. -- error compiling committee.c: too many arguments to function ------------------------------------------------------------------------- This SF.net email is sponsored by: Splunk Inc. Still grepping through log files to find problems? Stop. Now Search log events and configuration files using AJAX and a browser. Download your FREE copy of Splunk now >> http://get.splunk.com/