From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH] KVM: Remove arch specific components from the general code Date: Thu, 26 Jul 2007 14:05:01 +0300 Message-ID: <46A87FDD.7060308@qumranet.com> References: <20070726042948.5893.58975.stgit@novell1.haskins.net> <1185446238.4895.6.camel@localhost.localdomain> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org To: Rusty Russell Return-path: In-Reply-To: <1185446238.4895.6.camel-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org Errors-To: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: kvm.vger.kernel.org Rusty Russell wrote: > On Thu, 2007-07-26 at 00:31 -0400, Gregory Haskins wrote: > >> This is a cleanup patch to "de-VMX" the general code. It was developed in the >> preempt-hooks branch, but it should apply elsewhere as well. >> > > Hi Gregory, > > Great minds think alike. This is a little rough, but I decided to send > it out tonight because it would make your life easier... > What about my life? Which patch should I apply first? > === > Dynamically allocate vcpus > > This patch converts the vcpus array in "struct kvm" to a linked list > of VCPUs, and changes the "vcpu_create" and "vcpu_setup" hooks into > one "vcpu_create" call which does the allocation and initialization of > the vcpu (calling back into the kvm_vcpu_init core helper). > Linked list? So that the in-kernel apic code has to traverse a list, making sure the cpu still knows how to transfer dirty cache lines for every vcpu? A good old fashioned pointer array will suit just fine. > + spin_lock(&kvm->lock); > + /* What do we care if they create duplicate CPU ids? But be nice. */ > Oh, we care. Esp. the apic code. -- error compiling committee.c: too many arguments to function ------------------------------------------------------------------------- This SF.net email is sponsored by: Splunk Inc. Still grepping through log files to find problems? Stop. Now Search log events and configuration files using AJAX and a browser. Download your FREE copy of Splunk now >> http://get.splunk.com/