Re: [PATCH 4/4] Use kmem cache for allocating vcpus, simplify FPU ops

Avi Kivity
2007-07-30T10:26:04Z

Rusty Russell wrote:
> On Mon, 2007-07-30 at 12:12 +0300, Avi Kivity wrote:
>
>> Rusty Russell wrote:
>>
>>> If we use a kmem cache for allocating vcpus, we can get the 16-byte
>>> alignment required by fxsave & fxrstor instructions, and avoid
>>> manually aligning the buffer.
>>>
>> Please separate the slabification from the fpu cleanups into separate
>> patches.
>>
>
> Hmm, are you trying to get my patch count up?
>
>

I get a kickback on my signoffs.

>> Also, the allocation and destruction can be in common code, reducing the
>> amount of rarely-executed error paths.
>>
>
> Sure, we could pass the size into the core so it can allocate the slab
> cache, then have the core do the allocation itself (undoing the recent
> create_vcpu change).
>
> Is it worth it?
>

It isn't critical, but nice to have. I'd like to keep the code small.

--
error compiling committee.c: too many arguments to function