From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH 2/4] svm: pass vcpu_svm internally Date: Mon, 30 Jul 2007 12:03:45 +0300 Message-ID: <46ADA971.9030406@qumranet.com> References: <1185777103.12151.147.camel@localhost.localdomain> <1185777179.12151.149.camel@localhost.localdomain> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: kvm-devel To: Rusty Russell Return-path: In-Reply-To: <1185777179.12151.149.camel-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org Errors-To: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: kvm.vger.kernel.org Rusty Russell wrote: > container_of is wonderful, but not casting at all is better. This > patch changes svm.c's internal functions to pass "struct vcpu_svm" > instead of "struct kvm_vcpu" and using container_of. > > It also changes some internal function names: > 1) io_adress -> io_address (de-germanify the spelling) > 2) kvm_reput_irq -> reput_irq (it's not a generic kvm function) > 3) kvm_do_inject_irq -> (it's not a generic kvm function) > Please separate the renames from the de-container_of-fication. -- error compiling committee.c: too many arguments to function ------------------------------------------------------------------------- This SF.net email is sponsored by: Splunk Inc. Still grepping through log files to find problems? Stop. Now Search log events and configuration files using AJAX and a browser. Download your FREE copy of Splunk now >> http://get.splunk.com/