Re: [PATCH 2/4] svm: pass vcpu_svm internally

Avi Kivity
2007-07-30T09:03:45Z

Rusty Russell wrote:
> container_of is wonderful, but not casting at all is better. This
> patch changes svm.c's internal functions to pass "struct vcpu_svm"
> instead of "struct kvm_vcpu" and using container_of.
>
> It also changes some internal function names:
> 1) io_adress -> io_address (de-germanify the spelling)
> 2) kvm_reput_irq -> reput_irq (it's not a generic kvm function)
> 3) kvm_do_inject_irq -> (it's not a generic kvm function)
>

Please separate the renames from the de-container_of-fication.

--
error compiling committee.c: too many arguments to function