From: Avi Kivity <avi-atKUWr5tajBWk0Htik3J/w@public.gmane.org>
To: Laurent Vivier <Laurent.Vivier-6ktuUTfB/bM@public.gmane.org>
Cc: kvm-devel <kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org>
Subject: Re: unused assignment in kvm_setup_pio()
Date: Mon, 30 Jul 2007 16:57:35 +0300 [thread overview]
Message-ID: <46ADEE4F.2030306@qumranet.com> (raw)
In-Reply-To: <46ADED39.3040506-6ktuUTfB/bM@public.gmane.org>
Laurent Vivier wrote:
> I think line 1809 of kvm_main.c (from git) is useless, isn't it ???
>
> 1809 now = min(count, PAGE_SIZE / size);
> 1810
> 1811 if (!down)
> 1812 in_page = PAGE_SIZE - offset_in_page(address);
> 1813 else
> 1814 in_page = offset_in_page(address) + size;
> 1815 now = min(count, (unsigned long)in_page / size);
> 1816 if (!now) {
>
>
Yes. I hate that code.
--
error compiling committee.c: too many arguments to function
-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems? Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >> http://get.splunk.com/
next prev parent reply other threads:[~2007-07-30 13:57 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-30 13:52 unused assignment in kvm_setup_pio() Laurent Vivier
[not found] ` <46ADED39.3040506-6ktuUTfB/bM@public.gmane.org>
2007-07-30 13:57 ` Avi Kivity [this message]
[not found] ` <46ADEE4F.2030306-atKUWr5tajBWk0Htik3J/w@public.gmane.org>
2007-08-01 12:39 ` [PATCH] remove duplicate " Laurent Vivier
[not found] ` <46B07F1B.30202-6ktuUTfB/bM@public.gmane.org>
2007-08-01 18:51 ` Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46ADEE4F.2030306@qumranet.com \
--to=avi-atkuwr5tajbwk0htik3j/w@public.gmane.org \
--cc=Laurent.Vivier-6ktuUTfB/bM@public.gmane.org \
--cc=kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox